[SLOF] [PATCH v2] A new SLOF boot menu

Alexey Kardashevskiy aik at ozlabs.ru
Thu Jun 8 16:28:38 AEST 2017

On 07/06/17 19:33, Thomas Huth wrote:
> The current SLOF boot menu heavily depends on the contents of the
> "qemu,boot-list" and "qemu,boot-device"" properties in the device tree,
> so that the menu entries either look very strange (when there is no
> alias, see https://bugzilla.redhat.com/show_bug.cgi?id=1429832 ) or
> are duplicated (https://bugzilla.redhat.com/show_bug.cgi?id=1446018).
> A proper boot menu should rather show all available boot devices
> instead, so this patch series introduces a new boot menu (written in
> C this time) which is independent from the "qemu,boot-list/device"
> properties by looking at the available aliases instead. It is now also
> possible by selecting the entries with one key stroke only (you don't
> have to press RETURN anymore), so this is now hopefully much more user
> friendly than the old menu.
> Signed-off-by: Thomas Huth <thuth at redhat.com>

Thanks, applied.

This reminded me of an old problem if a patch adds a new file, and then you
do "git checkout HEAD^" (like with this one), dependencies are broken:

 ====== Building slof ======
        [CC]    Makefile.dep
make[2]: *** No rule to make target 'bootmenu.h', needed by 'paflof.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
Makefile:33: recipe for target 'slof' failed
make[1]: *** [slof] Error 2
Makefile:54: recipe for target 'qemu' failed
make: *** [qemu] Error 2

If/when you have time, could you please look at this too?

> ---
>  v2:
>  - Fixed nits from v1
>  - Squashed all patches together


More information about the SLOF mailing list