[SLOF] [PATCH] Use TYPE for the standard output instead of io_putchar()
thuth at redhat.com
Wed Jun 7 00:48:33 AEST 2017
On 06.06.2017 08:28, Alexey Kardashevskiy wrote:
> On 01/06/17 22:38, Thomas Huth wrote:
>> All stdout text from the C code of the paflof binary (e.g. all output
>> from printf() and friends) is currently only written via io_putchar()
>> to the hvterm console. If the user decided to use a VGA display instead,
>> the text is currently not shown there. This is especially affecting the
>> output of the TFTP boot functions which are using printf() to provide
>> valuable information like IP addresses and progress indication to the
>> user. Let's fix this nuisance by routing the stdout text through the
> Why not stderr as well?
Normal output for the user should not go through stderr, so we do not
urgently need to print this to the VGA console. And there are some few
spots in paflof() where you can not use printf() if it is routed through
TYPE (between init_engine=1 and the first initialization of TYPE), so we
should keep a way to print debugging information without TYPE, too.
That's why it is better to keep stderr mapped to io_putchar() right now.
More information about the SLOF