[SLOF] [PATCH 0/4] A new SLOF boot menu

[Nikunj A Dadhania]

Thomas Huth <thuth at redhat.com> writes:

> The current SLOF boot menu heavily depends on the contents of the
> "qemu,boot-list" and "qemu,boot-device"" properties in the device tree,
> so that the menu entries either look very strange (when there is no
> alias, see https://bugzilla.redhat.com/show_bug.cgi?id=1429832 ) or
> are duplicated (https://bugzilla.redhat.com/show_bug.cgi?id=1446018).
>
> A proper boot menu should rather show all available boot devices
> instead, so this patch series introduces a new boot menu which is
> independent from the "qemu,boot-list/device" properties by looking
> at the available aliases instead. It's now also possible by selecting
> the entries with one key stroke only (you don't have to press RETURN
> anymore), so this is now hopefully much more user friendly than the
> old menu.
>
> Thomas Huth (4):
>   bootmenu: Add framework for a new libbootmenu module
>   bootmenu: Gather devices and print the menu
>   bootmenu: Implement keyboard handling and boot menu selection
>   bootmenu: Wire up the new boot menu in the Forth code


The series looks good to me. For the full series:

Reviewed-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>

>
>  board-qemu/Makefile           |   2 +-
>  board-qemu/slof/Makefile      |   9 ++-
>  lib/Makefile                  |   2 +-
>  lib/libbootmenu/Makefile      |  49 ++++++++++++
>  lib/libbootmenu/bootmenu.c    | 181 ++++++++++++++++++++++++++++++++++++++++++
>  lib/libbootmenu/bootmenu.code |  20 +++++
>  lib/libbootmenu/bootmenu.h    |  15 ++++
>  lib/libbootmenu/bootmenu.in   |  15 ++++
>  slof/fs/start-up.fs           |  71 +++--------------
>  9 files changed, 297 insertions(+), 67 deletions(-)
>  create mode 100644 lib/libbootmenu/Makefile
>  create mode 100644 lib/libbootmenu/bootmenu.c
>  create mode 100644 lib/libbootmenu/bootmenu.code
>  create mode 100644 lib/libbootmenu/bootmenu.h
>  create mode 100644 lib/libbootmenu/bootmenu.in
>
> -- 
> 1.8.3.1