[SLOF] [PATCH] pci-scan: Fix pci-bridge-set-mem-base and pci-bridge-set-mem-limit

Alexey Kardashevskiy aik at ozlabs.ru
Sat Jul 22 13:35:30 AEST 2017

On 22/07/17 06:30, Segher Boessenkool wrote:
> On Fri, Jul 21, 2017 at 12:08:02PM +1000, Alexey Kardashevskiy wrote:
>> I have no doubts the patch fixes the problem.
>> I just wonder if it could be made easier to follow by adding separate words
>> for mem64 - pci-bridge-set-mem64-base/pci-bridge-set-mem64-limit - just
>> like we have them for pci-{next|max}-{mem|mmio|io}. Also stack comments are
>> useful, more than sentences imho. And every time you want to add a comment
>> like "\ Align variable to 1MB boundary" to few lines of code - just make it
>> a separate word - "pci-next-mem-align-1mb" - which won't even need comments
>> (look who I am telling it to) :)
> If you need names that long, and *still* the name does not make clear
> what the word does, you probably need to factor differently ;-)

Probably, I am open for suggestions :) I've posted v2, is it any clearer
what the patches are doing and how?


More information about the SLOF mailing list