[SLOF] [PATCH slof 1/3] pci-scan: Move bits around

Thomas Huth thuth at redhat.com
Fri Jul 21 18:18:27 AEST 2017


On 21.07.2017 09:35, Alexey Kardashevskiy wrote:
> This rearranges code to make next patch simpler. While we are here,
> this makes one functional change: in addition to checking
> the config space for 64bit support, this also checks pci-next-mem64.
> 
> This should cause no behavioral change.

The patch is quite hard to read since you've changed both, code and
indentation at the same time. If you really want to do this the clean
way, I suggest to fix the indentation first (maybe even in the whole
file), and then to do the code refactoring.

 Thomas


More information about the SLOF mailing list