[SLOF] [PATCH] pci: Improve the pci-var-out debug function

Thomas Huth thuth at redhat.com
Fri Jul 14 19:46:01 AEST 2017


Print all related variables, using the code from phb-parse-ranges in
board-qemu/slof/pci-phb.fs, so that we can easily check all the values
from the SLOF prompt, too.

Signed-off-by: Thomas Huth <thuth at redhat.com>
---
 board-qemu/slof/pci-phb.fs |  9 +--------
 slof/fs/pci-scan.fs        | 11 ++++++++---
 2 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/board-qemu/slof/pci-phb.fs b/board-qemu/slof/pci-phb.fs
index 926efba..06729bc 100644
--- a/board-qemu/slof/pci-phb.fs
+++ b/board-qemu/slof/pci-phb.fs
@@ -277,14 +277,7 @@ setup-puid
    THEN
 
    phb-debug? IF
-     ." pci-next-io   = " pci-next-io @ . cr
-     ." pci-max-io    = " pci-max-io  @ . cr
-     ." pci-next-mem  = " pci-next-mem @ . cr
-     ." pci-max-mem   = " pci-max-mem  @ . cr
-     ." pci-next-mmio = " pci-next-mmio @ . cr
-     ." pci-max-mmio  = " pci-max-mmio @ . cr
-     ." pci-next-mem64  = " pci-next-mem64 @ . cr
-     ." pci-max-mem64   = " pci-max-mem64  @ . cr
+      pci-var-out
    THEN
 ;
 
diff --git a/slof/fs/pci-scan.fs b/slof/fs/pci-scan.fs
index 9578189..c39707a 100644
--- a/slof/fs/pci-scan.fs
+++ b/slof/fs/pci-scan.fs
@@ -59,9 +59,14 @@ here 100 allot CONSTANT pci-device-vec
 
 \ prints out all relevant pci variables
 : pci-var-out ( -- )
-        s"   mem:" type pci-next-mem @ 16 0.r cr
-        s"  mmio:" type pci-next-mmio @ 16 0.r cr
-        s"    io:" type pci-next-io @ 16 0.r cr
+    ." pci-next-io    = " pci-next-io @ 10 0.r cr
+    ." pci-max-io     = " pci-max-io @ 10 0.r cr
+    ." pci-next-mem   = " pci-next-mem @ 10 0.r cr
+    ." pci-max-mem    = " pci-max-mem @ 10 0.r cr
+    ." pci-next-mmio  = " pci-next-mmio @ 10 0.r cr
+    ." pci-max-mmio   = " pci-max-mmio @ 10 0.r cr
+    ." pci-next-mem64 = " pci-next-mem64 @ 10 0.r cr
+    ." pci-max-mem64  = " pci-max-mem64 @ 10 0.r cr
 ;
 
 
-- 
1.8.3.1



More information about the SLOF mailing list