[SLOF] [PATCH 2/2] board-qemu: add private hcall to inform host on "phandle" update
groug at kaod.org
Tue Jul 11 02:34:39 AEST 2017
On Mon, 10 Jul 2017 11:19:49 -0500
Segher Boessenkool <segher at kernel.crashing.org> wrote:
> On Mon, Jul 10, 2017 at 05:40:14PM +0200, Greg Kurz wrote:
> > > > Dito - use ?dup and remove the "ELSE drop" part.
> > >
> > > In general, this needs to be much better factored if it wants to be
> > > readable at all. As soon as you need indentation to make any sense
> > > of your structure, you need to factor more.
> > Not sure I have enough forth background to understand... are
> > you suggesting that each level of indentation calls for the
> > introduction of a new word ?
> Not exactly. I am saying that if you make your word bodies huge and
> complex, you have a hard time understanding them. Indenting stuff
> (and adding stack comments for each line, or even after each word)
> helps a little bit, but it's a crutch.
Ok, I get it better now.
> If you have a hard time modifying some code because it is too complex,
> first factor it a bit better.
How did you guess I had hard time modifying this code ? ;)
I'll try to factor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 181 bytes
Desc: OpenPGP digital signature
More information about the SLOF