[SLOF] [PATCH v2] boot: do not use catpad to concatenate strings

[Nikunj A Dadhania]

Segher Boessenkool <segher at kernel.crashing.org> writes:

> On Thu, Dec 07, 2017 at 07:51:31AM +0100, Thomas Huth wrote:
>> > diff --git a/slof/fs/boot.fs b/slof/fs/boot.fs
>> > index 1fd7439..8a30195 100644
>> > --- a/slof/fs/boot.fs
>> > +++ b/slof/fs/boot.fs
>> > @@ -15,6 +15,9 @@
>> >  VARIABLE state-valid false state-valid !
>> >  CREATE go-args 2 cells allot go-args 2 cells erase
>> >  
>> > +4000 CONSTANT BOOT_DEV_SIZE
>> > +CREATE bootdev-buf BOOT_DEV_SIZE allot
>> 
>> I somehow dislike the idea that we statically reserve such big arrays
>> ... would it be feasible to do this with alloc-mem on the fly instead?
>
> And don't use underscores in names please; even if you like underscores
> better than dashes, surely you like consistency more.  There's no need
> for caps either.  Etc.

Sure.

> I couldn't follow the code, fwiw, so it may be that it is not factored
> well (or it does totally strange things).

There were multiple locations that needed removal of $cat, while getting
rid of static buffer will try re-factoring.

Regards
Nikunj