[SLOF] [PATCH] Rework the printing of the SLOF logo during boot

Thomas Huth thuth at redhat.com
Wed Apr 26 14:47:22 AEST 2017


On 25.04.2017 12:18, Thomas Huth wrote:
> If the initial boot attempt fails, for example because the file
> that we downloaded via TFTP is not executable, or because the user
> exited grub instead of booting a kernel, SLOF prints out the ASCII
> art SLOF logo and the banner text twice. This is quite ugly.
> Also it is somewhat annoying that the logo is printed every time
> again if the later boot attempts failed, too. So fix this by
> printing the SLOF logo only once, at the end of "start-it", and
> by avoiding to print the banner twice during the first boot attempt,
> i.e. by adding the ".banner" command to the "boot" command only
> after we've done the first attempt via "start-it".
> 
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1443904
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
>  board-js2x/slof/OF.fs | 8 ++++++--
>  board-qemu/slof/OF.fs | 8 ++++++--
>  slof/fs/boot.fs       | 3 ---
>  slof/fs/start-up.fs   | 1 +
>  4 files changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/board-js2x/slof/OF.fs b/board-js2x/slof/OF.fs
> index a51f473..fecd081 100644
> --- a/board-js2x/slof/OF.fs
> +++ b/board-js2x/slof/OF.fs
> @@ -176,8 +176,6 @@ THEN
>  #include <slof-logo.fs>
>  #include <banner.fs>
>  
> -: .banner .slof-logo .banner ;
> -

OK, looks like I need to refresh this patch now that the slof-logo has
been removed ... I'll send a v2...

 Thomas



More information about the SLOF mailing list