[SLOF] [PATCH 4/4] Provide "write" function in the disk-label package

[Alexey Kardashevskiy]

On 24/11/16 18:08, Thomas Huth wrote:
> On 24.11.2016 08:04, Nikunj A Dadhania wrote:
>> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>>
>>> On 16/11/16 00:02, Thomas Huth wrote:
>>>> As with the "read" function, the disk-label package should
>>>> forward the "write" function to its parent.
>>>>
>>>> Reviewed-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
>>>> Signed-off-by: Thomas Huth <thuth at redhat.com>
>>>
>>> After this patch, I cannot boot a guest at all:
>>
>> Works for me with the below command-line, am I missing something?
> 
> Did you try to use a "grub-reboot" command, so that grub also tries to
> write to the disk?

Where/why would I use this "grub-reboot"? :) I just tried a disk image with
2 kernels to see if grub writes/reads the last choice.


>>> qemu-system-ppc64: Incorrect order for descriptors
>>>
>>>
>>> This is my cmdline (basically, virtio-scsi):
> 
> Sorry, I did not check virtio-scsi, only vscsi and virtio-blk ... I'll
> have a look ...

I am missing the point of virtio-blk and (especially) ibmvscsi, is there
any case when either is better than virtio-scsi?

btw I tried that "virtio-scsi: Fix descriptor order for SCSI WRITE
commands", it helped, now it boots and remembers the last choice, thanks!


-- 
Alexey