[SLOF] [PATCH 4/4] Provide "write" function in the disk-label package

[Nikunj A Dadhania]

Alexey Kardashevskiy <aik at ozlabs.ru> writes:

> On 16/11/16 00:02, Thomas Huth wrote:
>> As with the "read" function, the disk-label package should
>> forward the "write" function to its parent.
>> 
>> Reviewed-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
>> Signed-off-by: Thomas Huth <thuth at redhat.com>
>
> After this patch, I cannot boot a guest at all:

Works for me with the below command-line, am I missing something?

> qemu-system-ppc64: Incorrect order for descriptors
>
>
> This is my cmdline (basically, virtio-scsi):
>
> /home/aik/p/qemu/ppc64-softmmu/qemu-system-ppc64 -nodefaults -chardev
> stdio,id=STDIO0,signal=off,mux=on -device
> spapr-vty,id=svty0,chardev=STDIO0,reg=0x71000100 -mon
> id=MON0,chardev=STDIO0,mode=readline -nographic -vga none -enable-kvm
> -device virtio-scsi-pci,id=vscsi0 -drive
> id=DRIVE0,if=none,file=img/u16_04_32G_htx_406.qcow2,format=qcow2 -device
> scsi-disk,id=scsi-disk0,drive=DRIVE0 -bios ./slof.bin -machine pseries
>

./ppc64-softmmu/qemu-system-ppc64 -nodefaults -chardev  stdio,id=STDIO0,signal=off,mux=on -device spapr-vty,id=svty0,chardev=STDIO0,reg=0x71000100 -mon id=MON0,chardev=STDIO0,mode=readline -nographic -vga none -device virtio-scsi-pci,id=vscsi0 -drive id=DRIVE0,if=none,file=./u1604.01.img  -device scsi-disk,id=scsi-disk0,drive=DRIVE0 -bios ./slof.bin -machine pseries --enable-kvm


SLOF **********************************************************************
QEMU Starting
 Build Date = Nov 24 2016 12:25:29
 FW Version = git-24559a3a2429004f
 Press "s" to enter Open Firmware.

Populating /vdevice methods
Populating /vdevice/nvram at 71000000
Populating /vdevice/vty at 71000100
Populating /pci at 800000020000000
                     00 0000 (D) : 1af4 1004    virtio [ scsi ]
Populating /pci at 800000020000000/scsi at 0
       SCSI: Looking for devices
          100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
No NVRAM common partition, re-initializing...
Scanning USB 
Using default console: /vdevice/vty at 71000100
     
  Welcome to Open Firmware

  Copyright (c) 2004, 2011 IBM Corporation All rights reserved.
  This program and the accompanying materials are made available
  under the terms of the BSD License available at
  http://www.opensource.org/licenses/bsd-license.php


Trying to load:  from: /pci at 800000020000000/scsi at 0/disk at 100000000000000 ...   Successfully loaded
error: no suitable video mode found.



                    GNU GRUB  version 2.02~beta2-36ubuntu3.2

 +----------------------------------------------------------------------------+
 | Ubuntu                                                                     | 


Regards
Nikunj