[SLOF] [PATCH v5 1/3] ping: report success on localhost ping

Nikunj A Dadhania nikunj at linux.vnet.ibm.com
Wed May 4 18:17:55 AEST 2016


Alexey Kardashevskiy <aik at ozlabs.ru> writes:

> On 05/04/2016 02:29 PM, Nikunj A Dadhania wrote:
>> Signed-off-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
>> Reviewed-by: Thomas Huth <thuth at redhat.com>
>
> I do not like this one.
>
> This "localhost" is not actually 127.0.0.1 so the subj is wrong.
>
> And I am missing the point here - ping is to make the IP stack work, at 
> least to make sure that the IP address is assigned but the patch does none 
> of it, just replies success.

Yes, its a hack just to support if someone pings <self>, which was
failing. You can drop this.

Regards,
Nikunj



More information about the SLOF mailing list