[SLOF] [PATCH] fat-files: Add dir support
aik at ozlabs.ru
Mon Jun 27 14:15:15 AEST 2016
On 09/06/16 18:08, Benjamin Herrenschmidt wrote:
> On Thu, 2016-06-09 at 02:24 -0500, Segher Boessenkool wrote:
>> On Thu, Jun 09, 2016 at 01:47:43PM +1000, Benjamin Herrenschmidt
>>> : seek ( lo hi -- status )
>>> + dir? @ IF ABORT" fat-files: trying to seek a dir" THEN
>> ABORT" has an IF built-in, so this should be
>> dir? @ ABORT" fat-files: trying to seek a dir"
>>> : dir
>>> - dir? @ IF file-cluster @ .dir ELSE ." not a directory!" cr THEN
>>> + dir? @ IF file-cluster @ .dir ELSE cr ." not a directory!" THEN
>> Belongs in the other patch?
>>> : open
>>> 0 my-args find-path
>>> - 0= IF free-data false EXIT
>>> - THEN
>>> - dir? ! file-len ! file-cluster !
>>> - dir? @ IF
>>> + 0= IF close false EXIT THEN
>>> + dir? ! file-len ! file-cluster !
>>> + dir? @ 0= IF
>>> 0 0 seek 0=
>>> ELSE true THEN
>> This as well, I guess?
> Nah I mixed up the patches. The global dir method should only
> touch boot.fs and everything in fat-files.fs should be in this one.
> I'll resend tomorrow after addressing your comments.
When you resend, "git send-mail" (or whatever you do for kernel/qemu)
please as this patch, "Add a global "dir" method" and "instance: Fix
set-my-args for empty arguments" are poisoned with 0xa0 too. Thanks.
More information about the SLOF