[SLOF] [PATCH] Add a global "dir" method

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Jun 9 22:13:41 AEST 2016

On Thu, 2016-06-09 at 03:27 -0500, Segher Boessenkool wrote:
> Yes, ten gazillion inputs and outputs now ;-)
> You already store that state slightly later, why not do it here already
> and have simpler code, much easier to read?

I tried, I actually had it that way... not that much easier and I'm
paranoid. If I want to come back in 2 years and use find-path for
something else, and forget it clobbers the global is-dir ... I really
really hate side effects :)

> If a word is hard to follow try factoring it.  Stack comments inside
> a word are almost always a bad idea.

I like how the firmworks code is done, they always have a right column
with the stack state ;-)


More information about the SLOF mailing list