[SLOF] [PATCH] Remove dependency on cpu/@0 for booting

[David Gibson]

On Wed, Jul 27, 2016 at 12:06:06PM +0530, Nikunj A Dadhania wrote:
> Segher Boessenkool <segher at kernel.crashing.org> writes:
> 
> > On Wed, Jul 27, 2016 at 09:47:47AM +0530, Nikunj A Dadhania wrote:
> >>  \ Fixup timebase frequency from device-tree
> >>  : fixup-tbfreq
> >> -    " /cpus/@0" find-device
> >> +    " /cpus" find-device
> >> +    get-node child ?dup 0= IF ABORT" start-cpu not found" THEN
> >> +    set-node
> >
> > ABORT" has an IF built in.  It also empties the stack, so this is just
> >
> >    get-node child dup 0= ABORT" start-cpu not found"
> 
> Sure.
> 
> > What guarantees this finds the "start-cpu"?
> 
> QEMU does not allow to remove last CPU.

More to the point, if there are no CPUs, presumably there's nothing to
execute this code in the first place.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/slof/attachments/20160727/158907b5/attachment.sig>