[SLOF] [PATCH slof v2] readme: Add a note about coding style

Thomas Huth thuth at redhat.com
Fri Jan 29 20:40:49 AEDT 2016


On 29.01.2016 07:16, Alexey Kardashevskiy wrote:
> This is an attempt to standartize the coding style in the project.
> 
> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
> ---
>  README | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
...
> @@ -247,6 +248,24 @@ confirm that you certify the Developer Certificate of Origin  Version 1.1,
>  see [3] for details.
>  
>  
> +5.0 Coding style
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +
> +New C code submitted to SLOF should follow the coding style guidelines
> +for the Linux kernel [4] with the following exceptions:
> +
> +- in the event that you require a specific width, use a standard type
> +  like int32_t, uint32_t, uint64_t, etc. Don't use Linux kernel internal
> +  types like u32, __u32 or __le32.
> +
> +New forth code should use 4 space indentations and no tabs. Patches for

s/forth/Forth/

> +the old code should keep the existing style which usually is
> +3 space indentation.
> +
> +New assembly code submitted to SLOF should follow the coding style
> +guidelines for the Linux kernel [4], i.e. indent with tabs, not with spaces.

With the above nit fixed:

Reviewed-by: Thomas Huth <thuth at redhat.com>



More information about the SLOF mailing list