[SLOF] [PATCH v4 13/23] virtio-net: move setup-mac to the open routine

Thomas Huth thuth at redhat.com
Fri Jan 29 03:56:04 AEDT 2016


On 28.01.2016 11:24, Nikunj A Dadhania wrote:
> MAC reading should be done after the initialization of the device after
> the features negotiation.
> 
> Adjust the open routine accordingly. There is no point in sending the
> mac address to the virtionet_open. Change the signature. Also read the
> mac address directly from the config space to remove the dependency of
> getting the mac address from the open routine.
> 
> Signed-off-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
> ---
>  board-qemu/slof/virtio-net.fs | 30 ++++++++++++++----------------
>  lib/libvirtio/virtio-net.c    |  7 ++++---
>  lib/libvirtio/virtio-net.h    |  2 +-
>  lib/libvirtio/virtio.code     |  8 +++-----
>  4 files changed, 22 insertions(+), 25 deletions(-)

Looks fine to me now!

Reviewed-by: Thomas Huth <thuth at redhat.com>



More information about the SLOF mailing list