[SLOF] [PATCH v3 05/22] virtio: introduce helper for initializing virt queue

Nikunj A Dadhania nikunj at linux.vnet.ibm.com
Wed Jan 27 16:36:17 AEDT 2016


Alexey Kardashevskiy <aik at ozlabs.ru> writes:

> On 01/22/2016 09:54 PM, Nikunj A Dadhania wrote:
>> The routine takes care to allocate and set the queue address in the
>> device. Add these calls in virtio-net, virtio-blk and virtio-9p.
>>
>> With the lack of this routine, devices like virtio-blk and virtio-9p did
>> not do a device reset in the driver initialization code. This helper
>> will fix that problem
>>
>> Change the signature of virtio_set_qaddr, accepting queue address as
>> unsigned long argument.


>> -		dprintf("%i: vq.id = %llx\nvq.size =%x\n vq.avail =%p\nvq.used=%p\n",
>> -			i, vq[i].id, vq[i].size, vq[i].avail, vq[i].used);
>> +	if (virtio_queue_init_vq(dev, &vq[VQ_RX], VQ_RX) ||
>> +	    virtio_queue_init_vq(dev, &vq[VQ_TX], VQ_TX)) {
>> +		virtio_set_status(dev, VIRTIO_STAT_ACKNOWLEDGE|VIRTIO_STAT_DRIVER
>> +    				  |VIRTIO_STAT_FAILED);
>
>
>
> Applying: virtio: introduce helper for initializing virt queue
> /home/aik/p/slof/.git/rebase-apply/patch:161: space before tab in indent.
>      				  |VIRTIO_STAT_FAILED);
> warning: 1 line adds whitespace errors.

Will fix.



More information about the SLOF mailing list