[SLOF] [PATCH slof] readme: Add a note about coding style

Thomas Huth thuth at redhat.com
Mon Jan 25 21:22:34 AEDT 2016

On 25.01.2016 02:41, Alexey Kardashevskiy wrote:
> This is an attempt to standartize the coding style in the project.
> @@ -247,6 +248,21 @@ confirm that you certify the Developer Certificate of Origin  Version 1.1,
>  see [3] for details.
> +5.0 Coding style
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +
> +New C code submitted to SLOF should follow the coding style guidelines
> +for the Linux kernel [4] with the following exceptions:

Currently, it's only one exception, so maybe remove the "s" at the end
of exceptions?

> +- in the event that you require a specific width, use a standard type
> +like int32_t, uint32_t, uint64_t, etc. Don't use Linux kernel internal
> +types like u32, __u32 or __le32.

I'd maybe indent the "like ..." and "types ..." lines with two spaces so
that they match the "in" of the first line? Or remove the "-" in the
first line since this there is only this one item for now?

> +New forth code should use 4 space indentations and no tabs. Patches for
> +the old code should keep the existing style which usually is
> +3 space indentation.

BTW, what about assembler code? Maybe mention the indentation rules for
that, too? (indent with tabs?)


More information about the SLOF mailing list