[SLOF] [PATCH slof v3 2/4] net-snk: Fix gcc warnings

[Alexey Kardashevskiy]

On 01/22/2016 07:42 PM, Nikunj A Dadhania wrote:
> Nikunj A Dadhania <nikunj at linux.vnet.ibm.com> writes:
>
>> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>>
>>> On 01/22/2016 04:54 PM, Nikunj A Dadhania wrote:
>>>> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>>>>
>>>>> This replaces some local variable types and some function parameters from
>>>>> signed to unsigned to fix gcc warnings.
>>>>
>>>> What switch are you using to get the gcc warnings? Default build doesnt
>>>> give me any !
>>>
>>> This is how I build it:
>>>
>>> make qemu WARNFLAGS=-Wextra
>>
>> You should mention that in the commit log.


I will. Want respin or I can just push it? :)


>>
>>>
>>> btw this produces quite many warnings in virtio-1.0 ;)
>>
>> Sure, will test that :-)
>
> I tried doing the following:
>
> Before my commits:
>      $ make clean && CROSS=powerpc64-linux-gnu- make qemu  WARNFLAGS=-Wextra 1>/dev/null 2>before_v1.0
>      $ grep virtio before_v1.0 | grep warning | wc -l
>      4
>      $
>
> After my commits:
>      $ make clean && CROSS=powerpc64-linux-gnu- make qemu  WARNFLAGS=-Wextra 1>/dev/null 2>after_v1.0
>      $ grep virtio after_v1.0 | grep warning | wc -l
>      6
>      $


v3 of your virtio 1.0 did not produce any => good.


-- 
Alexey