[SLOF] [PATCH v3 08/22] virtio-{net, blk, scsi, 9p}: use status variable

Thomas Huth thuth at redhat.com
Sat Jan 23 17:38:15 AEDT 2016


On 22.01.2016 11:54, Nikunj A Dadhania wrote:
> The virtio_set_status lines were getting too long because of OR'ing the
> status on the same line of the call. Moreover, going forward we need to
> add FEATURES_OK status as well. The state progress is quite straight
> forward, so use status variable instead. Code looks cleaner and can easily
> make out the change in the state.
> 
> Signed-off-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
> ---
>  lib/libvirtio/virtio-9p.c   | 23 ++++++++++++++---------
>  lib/libvirtio/virtio-blk.c  | 22 +++++++++++++---------
>  lib/libvirtio/virtio-net.c  | 16 ++++++++++------
>  lib/libvirtio/virtio-scsi.c | 10 ++++++----
>  4 files changed, 43 insertions(+), 28 deletions(-)

Thanks for the patch description, patch now makes sense to me :-)

Reviewed-by: Thomas Huth <thuth at redhat.com>



More information about the SLOF mailing list