[SLOF] [PATCH v2 16/19] virtio: add and enable 1.0 capability parsing

Nikunj A Dadhania nikunj at linux.vnet.ibm.com
Fri Jan 22 16:28:36 AEDT 2016


Alexey Kardashevskiy <aik at ozlabs.ru> writes:

> On 01/20/2016 11:10 PM, Nikunj A Dadhania wrote:
>> Introcduce parsing routines for virtio capabilities. This would also
>
> s/Introcduce/Introduce/

Sure.

>> +
>> +	if (cap && cfg_type) {
>> +		cap->bar = bar;
>> +		addr = SLOF_pci_config_read32(PCI_BASE_ADDR_REG_0 + 4 * cap->bar);
>> +		if (addr & PCI_BASE_ADDR_SPACE_IO) {
>> +			cap->is_io = 1;
>> +			addr = addr & PCI_BASE_ADDR_IO_MASK;
>> +		} else if (addr & 4) {
>
>
> Define a macro for "4" too?

Sure,



More information about the SLOF mailing list