[SLOF] [PATCH v1 00/27] Generic virtio 1.0 with block and network enabled

[Nikunj A Dadhania]

Alexey Kardashevskiy <aik at ozlabs.ru> writes:

> On 01/13/2016 10:16 PM, Nikunj A Dadhania wrote:
>> This is the first shot at enabling virtio 1.0 driver support in the SLOF.
>> Enables virtio-blk and virtio-net drivers for 1.0.
>>
>> The patchset is divided in following categories:
>>
>> patch 01-05: Generic fixes and prepartion for 1.0
>> patch 06-20: Virtio 1.0 generic layer updates
>> patch 21: Virtio-blk enablement
>> patch 22-25: Preparation for virtio-net
>> patch 26: virtio-net 1.0 enablement
>> patch 27: Enables modern devices (device ids 1041)
>
>
> I'd suggest the following sequence:


Sure, let me try re-ordering the series, will post after that.

>
> - fix code design issues - tabs/spaces; (optionally) do here replacing "if 
> (dev->type == VIRTIO_TYPE_PCI)" with "if (dev->type != VIRTIO_TYPE_PCI)", 
> etc to make the following patches look simpler
>
> - add helpers like  SLOF_pci_config_read8()
>
> - fix virtio_set_qaddr()
>
> - add fill_blk_hdr(), virtio_queue_init_vq() and change virtio-blk/net to 
> use these
>
> and only then start doing things like "1.0 aware" or adding 
> virtio-setup-device.
>
> Otherwise jumping back and forth in the series is really exhausting :)

Intention was the opposite :-)

Regards
Nikunj