[SLOF] [PATCH v1 06/27] virtio: add virtio 1.0 related struct and defines
Nikunj A Dadhania
nikunj at linux.vnet.ibm.com
Thu Jan 14 22:52:28 AEDT 2016
Thomas Huth <thuth at redhat.com> writes:
> On 14.01.2016 11:33, Nikunj A Dadhania wrote:
>> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>>
>>> On 01/13/2016 10:16 PM, Nikunj A Dadhania wrote:
>>>> Signed-off-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
>>>> ---
>>>> board-qemu/slof/virtio.fs | 14 ++++++++++++++
>>>> lib/libvirtio/virtio.h | 33 ++++++++++++++++++++++++++++++---
>>>> 2 files changed, 44 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/board-qemu/slof/virtio.fs b/board-qemu/slof/virtio.fs
>>>> index 818c132..29d0a19 100644
>>>> --- a/board-qemu/slof/virtio.fs
>>>> +++ b/board-qemu/slof/virtio.fs
>>>> @@ -14,8 +14,22 @@
>>>> STRUCT
>>>> /n FIELD vd>base
>>>> /l FIELD vd>type
>>>> + /l FIELD vd>is-modern
>>>> + 16 FIELD vd>legacy
>>>
>>> Why not /w?
>>
>> 16 bytes field
>
> Please keep in mind that SLOF is running in hexadecimal mode by default
> ... so you should be using "10" instead?
Yes, indeed.
>
>>>> +/* VIRTIO 1.0 Device independent feature bits */
>>>> +#define VIRTIO_F_RING_INDIRECT_DESC BIT(28)
>>>> +#define VIRTIO_F_RING_EVENT_IDX BIT(29)
>>>> +#define VIRTIO_F_VERSION_1 BIT(32)
>>>> +
>>>> #define VIRTIO_TIMEOUT 5000 /* 5 sec timeout */
>>>>
>>>> /* Definitions for vring_desc.flags */
>>>> @@ -34,7 +43,7 @@ struct vring_desc {
>>>> uint32_t len; /* Length */
>>>> uint16_t flags; /* The flags as indicated above */
>>>> uint16_t next; /* Next field if flags & NEXT */
>>>> -};
>>>> +};
>>>
>>> Unrelated whitespace change?
>>
>> As I was at this file I changed, I can submit as a separate patch if
>> needed.
>
> +1 for using a separate patch
>
> Thomas
More information about the SLOF
mailing list