[SLOF] [PATCH] Fix format strings in usb-ohci.c

Thomas Huth thuth at redhat.com
Mon Jan 11 18:15:00 AEDT 2016


On 11.01.2016 02:05, Alexey Kardashevskiy wrote:
> On 01/09/2016 02:04 AM, Thomas Huth wrote:
>> When compiling with OHCI_DEBUG enabled, gcc complains about a
>> lot of bad format strings. So let's use more appropriate format
>> modifiers to fix these warnings.
>>
>> Signed-off-by: Thomas Huth <thuth at redhat.com>
> 
> Thanks, applied.
> 
> but how exactly did you test it? "make qemu WARNFLAGS=-Wextra" did not
> produce any warning, with or without this patch, on gcc 5.1.1 and 5.2.1.

I simply enabled the "#define OHCI_DEBUG" at the beginning of usb-ohci.c
and then GCC started to spill out the warnings.

 Thomas



More information about the SLOF mailing list