[SLOF] RFC: cp codes

[Dinar Valeev]

On 24 Feb 2016 10:10, "Thomas Huth" <thuth at redhat.com> wrote:
>
> On 24.02.2016 09:44, Dinar Valeev wrote:
> > On Wed, Feb 24, 2016 at 9:34 AM, Alexey Kardashevskiy <aik at ozlabs.ru>
wrote:
> >> On 02/24/2016 06:45 PM, Thomas Huth wrote:
> >>> On 23.02.2016 16:15, Dinar Valeev wrote:
> >>>> On Mon, Feb 15, 2016 at 7:09 PM, Thomas Huth <thuth at redhat.com>
wrote:
> >>>>> On 10.02.2016 13:19, Thomas Huth wrote:
> >>>>>> On 10.02.2016 01:33, Alexey Kardashevskiy wrote:
> >>>>>>> On 02/09/2016 11:54 PM, Dinar Valeev wrote:
> >>>>>>>> On Mon, Feb 8, 2016 at 6:50 PM, Thomas Huth <thuth at redhat.com>
wrote:
> >>>>>>>>> On 08.02.2016 15:10, Dinar Valeev wrote:
> >>>>>>>>>>
> >>>>>>>>>> I have long standing issue with SLOF. During start SLOF prints
cp
> >>>>>>>>>> codes with backspace:
> >>>>>>>>>>
> >>>>>>>>>>
https://github.com/aik/SLOF/blob/master/lib/libbootmsg/bootmsg_lvl.S#L61-L64
> >>>>>>>>>>
> >>>>>>>>>> We start a VM and record log, this is fine. But then when we
look
> >>>>>>>>>> at
> >>>>>>>>>> the log through WebUI, because of backspace, Mozilla thinks
this is
> >>>>>>>>>> a
> >>>>>>>>>> binary file.
> >>>
> >>> ...
> >>>>>
> >>>>> Just a completely different idea, but would the following patch
also fix
> >>>>> your issue?
> >>>>>
> >>>>> diff --git a/lib/libbootmsg/bootmsg_lvl.S
b/lib/libbootmsg/bootmsg_lvl.S
> >>>>> index 2e4c135..14ce4bf 100644
> >>>>> --- a/lib/libbootmsg/bootmsg_lvl.S
> >>>>> +++ b/lib/libbootmsg/bootmsg_lvl.S
> >>>>> @@ -58,10 +58,8 @@ ENTRY(bootmsg_cp)
> >>>>>          bl      io_putchar      // print character
> >>>>>          mr      r3, r9
> >>>>>          bl      io_printhex16   // print checkpoint ID
> >>>>> -       .rept   5
> >>>>> -       li      r3,'\b'
> >>>>> -       bl      io_putchar      // print backspaces
> >>>>> -       .endr
> >>>>> +       li      r3,'\r'
> >>>>> +       bl      io_putchar      // go back
> >>>>>          mtlr    r11
> >>>>>          blr
> >>>>>
> >>>>> Replacing 5 '\b's with one '\r' should IMHO be ok here since the
> >>>>> checkpoints should always be printed at the beginning of a line...
> >>>>
> >>>> I gave it a try.. It works flawlessly...
> >>>>
> >>>> Could you commit it?
> >>>
> >>>
> >>> That's a question for Alexey, I guess ... Alexey, what do you think,
is
> >>> that change ok?
> > I mean should I send a patch or you could do it?
>
> I just prepared and sent a patch.
Thanks
>
>  Thomas
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/slof/attachments/20160224/e4bda4bb/attachment.html>