[SLOF] [PATCH v2] dhcp: fix warning messages when calling strtoip()

Alexey Kardashevskiy aik at ozlabs.ru
Fri Feb 12 11:02:32 AEDT 2016

On 02/11/2016 05:28 PM, Nikunj A Dadhania wrote:
> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>> On 02/11/2016 03:55 PM, Nikunj A Dadhania wrote:
>>> Hi Alexey,
>>> Nikunj A Dadhania <nikunj at linux.vnet.ibm.com> writes:
>>>> With the removal of dupicate strtoip in patch "dhcp: Remove duplicated
>>>> strtoip()" (commit 896e31da2cc260bf5311a89b63683def20329c5b), we get
>>>> following warnings messages:
>>>> dhcp.c: In function ‘dhcpv4’:
>>> Commit on GitHub got some junk characters
>>> dhcp.c: In function ‘dhcpv4’:
>>> And many more places where "'" was there.
>> This is what you posted, I did not change a thing (does not really bother
>> me, and I thought I have fonts problem). Is there a problem?
> Better to fix next time around though.
> It basically converts "'" to some junk chars. Some problem with your

Your patch contained 0x2019 symbol, not 0x27 or 0x60.

> fonts. I dont see any issues here:
> https://lists.ozlabs.org/pipermail/slof/2016-February/000915.html

Sure, your patch looked fine in my mailer too because mozilla-gecko can 
render utf8 just fine, that's why I missed it.


More information about the SLOF mailing list