[SLOF] [PATCH] Fix remaining compiler warnings in sloffs.c

Segher Boessenkool segher at kernel.crashing.org
Wed Aug 10 05:41:12 AEST 2016

On Tue, Aug 09, 2016 at 12:15:42PM +0530, Nikunj A Dadhania wrote:
> > Don't you need to rather check for " i < udp_hdr->uh_ulen / 2" now?
> Right, missed that. And I think we need to take care for odd length as
> well.

Yes, both those.  The original code doesn't handle odd length correctly
either it seems.

The checksum magically works out with either BE or LE 16-bit accesses,
but you might want to make that explicit, too.


More information about the SLOF mailing list