[SLOF] [PATCH] xhci: fix missing keys from keyboard

Thomas Huth thuth at redhat.com
Fri Apr 29 17:24:53 AEST 2016


On 28.04.2016 22:03, Nikunj A Dadhania wrote:
> Current handling of the keyboard polling was very slow and
> keys were getting dropped. Done following for fixing this:
> 
> * Use multiple buffers per TRB
> * Allocate buffers in xhci according to the number of TRBS.
> 
> This reduces the delay of key? processing by getting rid of wait in 
> the polling routine. 
> 
> Reported-by: Dinar Valeev <k0da at opensuse.org>
> Signed-off-by: Nikunj A Dadhania <nikunj at linux.vnet.ibm.com>
> ---
> 
> Dinar, can you give this patch a test as well, logic is same, 
> some polishing and got rid of magic numbers.
> 
>  lib/libusb/usb-xhci.c | 52 +++++++++++++++++++++++++++++++++++++++------------
>  lib/libusb/usb-xhci.h |  2 ++
>  2 files changed, 42 insertions(+), 12 deletions(-)

I just tried your patch, and this fixes my issue with XHCI keyboard as
well! Thanks!

Tested-by: Thomas Huth <thuth at redhat.com>



More information about the SLOF mailing list