[SLOF] [PATCH v2 8/8] usb-xhci: add keyboard support

Alexey Kardashevskiy aik at ozlabs.ru
Tue Oct 6 13:32:51 AEDT 2015


On 10/05/2015 03:27 PM, Nikunj A Dadhania wrote:
> Alexey Kardashevskiy <aik at ozlabs.ru> writes:
>
>> On 09/18/2015 07:54 PM, Nikunj A Dadhania wrote:
>>>
>>> Missed a hunk in code re-org:
>>>
>>> @@ -616,6 +617,7 @@ static void xhci_free_dev(struct xhci_dev *xdev)
>>>    {
>>>    	xhci_free_seg(&xdev->bulk_in, XHCI_DATA_TRBS_SIZE);
>>>    	xhci_free_seg(&xdev->bulk_out, XHCI_DATA_TRBS_SIZE);
>>> +	xhci_free_seg(&xdev->intr, XHCI_INTR_TRBS_SIZE);
>>>    	xhci_free_seg(&xdev->control, XHCI_CONTROL_TRBS_SIZE);
>>>    	xhci_free_ctx(&xdev->in_ctx, XHCI_CTX_BUF_SIZE);
>>>    	xhci_free_ctx(&xdev->out_ctx, XHCI_CTX_BUF_SIZE);
>>>
>>> And added following in pipe cleanup path:
>>>
>>> @@ -1404,6 +1405,10 @@ static void xhci_put_pipe(struct usb_pipe *pipe)
>>>           if (pipe->type == USB_EP_TYPE_BULK) {
>>>                   xpipe = xhci_pipe_get_xpipe(pipe);
>>>                   xpipe->seg = NULL;
>>> +       } else if (pipe->type == USB_EP_TYPE_INTR) {
>>> +               xpipe = xhci_pipe_get_xpipe(pipe);
>>> +               SLOF_dma_map_out(xpipe->buf_phys, xpipe->buf, xpipe->buflen);
>>> +               xpipe->seg = NULL;
>>>           }
>>>           if (xhcd->end)
>>>                   xhcd->end->next = pipe;
>>
>>
>> So you'll repost, right? You can repost just this patch and I'll take the
>> rest from this series.
>
> I will repost just this patch. As nothing got changed in the previous
> patches.

Thanks, applied with "[SLOF] [PATCH v3] usb-xhci: add keyboard support".

afaict usb-kbd works now with XHCI and OHCI but not with EHCI, is that 
correct? To be clear, this patch set does not change that.




-- 
Alexey


More information about the SLOF mailing list