[SLOF] [PATCH v2 02/20] Add TPM initialization support

Thomas Huth thuth at redhat.com
Sat Nov 21 02:45:22 AEDT 2015

On 19/11/15 19:33, Stefan Berger wrote:
> On 11/19/2015 04:04 AM, Thomas Huth wrote:
>> I'm having a hard time to imagine what "unassert physical presence"
>> means ... could you please add a comment here to explain what this
>> function does? 
> The TCG specs talk a lot about 'assertion' of physical presence. A
> function that does that is added later in the patch series, when it is
> needed for executing certain TPM functionality using the menu. So this
> function does the opposite and we 'give up' physical presence. If I
> described this in some text above the function, is that sufficient or
> should I rename the function as well (tpm_giveup_physical_presence) ?

Ok, thanks for the explanation - I think a comment in the source should
do the job.


More information about the SLOF mailing list