[SLOF] [PATCH v2 20/20] make last entry in log appear
thuth at redhat.com
Fri Nov 20 23:32:42 AEDT 2015
On 19/11/15 18:51, Stefan Berger wrote:
> On 11/19/2015 12:05 PM, Thomas Huth wrote:
>> On 19/11/15 17:21, Stefan Berger wrote:
>>> On 11/19/2015 06:34 AM, Thomas Huth wrote:
>>>> On 17/11/15 18:02, Stefan Berger wrote:
>>>>> From: Stefan Berger <stefanb at linux.vnet.ibm.com>
>>>>> Due to the off-by-one error in Linux, we need to add a 1 to the
>>>>> actual size of the log.
>>>> If there's a bug in Linux, why don't you fix it there instead?
>>>> Introducing wrong behavior here sounds wrong to me.
>>> The problem is that this a bug that's been in Linux basically forever.
>>> So it's unfortunately 'cheaper' now to fix it here.
>> Well, I don't think so. It's maybe cheaper at a first glance, but
>> including hacks like this will most likely result in much more severe
>> problems in the future:
>> - What if PowerVM one day supports the vTPM interface (or does it
>> already?) ... should it also include this hack, or not ... and
>> then would this also be required for AIX etc. ...?
> PowerVM does already support the vTPM interface. Also here AIX has to
> watch out how it walks over the untrusted log / log buffer.
But PowerVM reports the right size of the log, not the size + 1 value?
So this bug already shows up in Linux when it runs under PowerVM? If so,
that's another indication that Linux should be fixed, not the firmware.
More information about the SLOF