[SLOF] [PATCH 06/16] Return value of actual log in sml-get-handover-size

[Nikunj A Dadhania]

Stefan Berger <stefanb at linux.vnet.ibm.com> writes:

> On 11/09/2015 04:06 AM, Nikunj A Dadhania wrote:
>> Stefan Berger <stefanb at linux.vnet.ibm.com> writes:
>>
>>> With the functions for calculating the actual size of the log in place,
>>> use them to determine the exact size of the log that the firmware
>>> API call sml-get-handover-size now returns.
>>>
>>> Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>
>>> ---
>>>   board-qemu/slof/vtpm-sml.fs |  4 ++--
>>>   lib/libtpm/tcgbios.c        | 15 +++++++++++++++
>>>   lib/libtpm/tcgbios.h        |  1 +
>>>   lib/libtpm/tpm.code         | 10 ++++++++++
>>>   lib/libtpm/tpm.in           |  1 +
>>>   5 files changed, 29 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/board-qemu/slof/vtpm-sml.fs b/board-qemu/slof/vtpm-sml.fs
>>> index 741a953..28c30f1 100644
>>> --- a/board-qemu/slof/vtpm-sml.fs
>>> +++ b/board-qemu/slof/vtpm-sml.fs
>>> @@ -37,9 +37,9 @@ log-base LOG-SIZE tpm-set-log-parameters
>>>
>>>   : sml-get-handover-size ( -- size )
>>>       vtpm-debug? IF
>>> -        ." Call to sml-get-handover-size; size = " LOG-SIZE . cr
>>> +        ." Call to sml-get-handover-size; size = " tpm-get-logsize . cr
>>>       THEN
>>> -    LOG-SIZE
>>> +    tpm-get-logsize
>>>   ;
>> Why call tpm-get-logsize twice in case of debug enabled ?
>>
>> : sml-get-handover-size ( -- size )
>>      tpm-get-logsize
>>      vtpm-debug? IF ." sml-get-handover-size: size = " dup . cr THEN
>> ;
>>
>> I think you should implement this word in this patch itself, do you need
>> sml-get-handover-size in the earlier patches ?
>
> It's not necessary to have it in the earlier patches...

Then we can move that piece of code here.

Regards
Nikunj