[SLOF] [PATCH 02/16] Add TPM initialization support

Thomas Huth thuth at redhat.com
Thu Nov 12 06:27:54 AEDT 2015

On 11/11/15 19:56, Stefan Berger wrote:
> On 11/09/2015 03:29 AM, Nikunj A Dadhania wrote:
>> Stefan Berger <stefanb at linux.vnet.ibm.com> writes:
>> This will be do { if (0)  { printf (); } } while(0);
>> which i assume compiler can optimize, but as suggested in earlier patch
>> can we make it more explicit ?
>> Variable names look foreign in the SLOF code !
> Is it the camel case? I can remove that. Or the fact that they use a
> mixture of lower and upper case? I find upper case constants in some
> parts of the code and lower case constants and then things like
> keycode_alt_GR (usb-key.c). If I insert _ before a upper case letter, is
> that sufficient ?

C code in SLOF should follow the Linux kernel coding style, see chapter
4 here: https://www.kernel.org/doc/Documentation/CodingStyle
So please avoid uppercase letters in variable names.


More information about the SLOF mailing list