[SLOF] [PATCH slof] qemu/js2x/client: Support binutils >= 2.25.1

Thomas Huth thuth at redhat.com
Mon Nov 2 18:44:05 AEDT 2015


On 02/11/15 02:40, Alexey Kardashevskiy wrote:
> On 10/26/2015 05:37 PM, Alexey Kardashevskiy wrote:
>> The recent binutils version introduces explicit definition of
>> a TOC symbol which points to the .toc section and enforces .toc
>> alignment to 256 rather than 8 bytes before.
>>
>> For now the TOC symbol points to same location as it was before -
>> start of .toc + 0x8000; however as this might change, we should not
>> rely on that in the source code.
>>
>> This changes __toc_start (for qemu and js2x boards), _got (for net-snk,
>> takeover, rtas) in linker scripts to use explicitely defined TOC if
>> defined and fall back to the older scheme if not.
>>
>> This changes r2 (the register pointing to TOC) setup code not to add
>> 0x8000 as linker scripts do that now.
> 
> 
> No opinion on this, really? So I just push it and then watch people
> complaining? :)

FWIW, I recently downloaded the "Advanced Toolchain Compiler v9.0"
suite, which is apparently based on 2.25.2, and after applying your
patch, SLOF was usable again. And it seems also to still work fine with
my older cross-compiler (GCC 4.8.1, binutils 2.23.2), so if you like,
you can add my:

Tested-by: Thomas Huth <thuth at redhat.com>



More information about the SLOF mailing list