[Slof] [PATCH 3/5] boot: remove trailing ":" in the bootpath

[Nikunj A Dadhania]

Thomas Huth <thuth at redhat.com> writes:

> On Mon, 6 Jul 2015 10:04:05 -0500
> Segher Boessenkool <segher at kernel.crashing.org> wrote:
>
>> On Mon, Jul 06, 2015 at 04:32:39PM +0530, Nikunj A Dadhania wrote:
>> >        -rot                              ( ihandle devstr len )
>> > -      my-args nip 0= IF
>> > -	 2dup 1- + c@ [char] : <> IF    \ Add : to device path if missing
>> > -	    1+ strdup 2dup 1- + [char] : swap c!
>> > -	 THEN
>> > -      THEN
>> >        encode-string s" bootpath" set-chosen
>> 
>> That looks fine to me, but someone added that on purpose; what was
>> that purpose, why is this code no longer needed/wanted?
>
> Looking at the SLOF git from Adrian (which can be cloned from
> http://lisas.de/~adrian/slof/slof.git) which contains the early open source
> releases of SLOF, it seems like this piece of code has been added
> before the first open source release already. So that information is
> likely not available anymore :-(

Yes, git history wasnt there, I had searched and asked around.

> Anyway, adding a ":" to the device path also does not make much sense
> to me here, so unless there's an old version of yaboot that requires
> this colon, I think it should be ok to remove it.
>
> Nikunj, did you have a try with some older version of yaboot whether
> they still work fine without that colon?

SUSE uses yaboot, and I have tested the yaboot from their distro:

    Welcome to yaboot version r22.8-r1190.SuSE

That boots fine.

Regards,
Nikunj