[SLOF] [PATCH v2 4/6] fbuffer: Implement RFILL as an accelerated primitive

Segher Boessenkool segher at kernel.crashing.org
Tue Aug 4 05:53:54 AEST 2015


On Mon, Aug 03, 2015 at 09:30:59PM +0200, Thomas Huth wrote:
> +	SET_CI; \
> +	while (size > 0) { \
> +		*d1++ = tmp; size -= sizeof(t); \
> +	} \
> +	CLR_CI; \

If you haven't tested this on a real 970, could you check if the
generated assembler is what you expect / want?  I.e. no extra memory
accesses (to stack or whatever) between the hid4 things.  I expect it
will "just work", but :-)

> +PRIM(RFILL)
> +	type_u pat = TOS.u; POP;
> +	type_u size = TOS.u; POP;
> +	void *dst = TOS.a; POP;
> +	FAST_RFILL(dst, size, pat);
> +	MIRP

Ah you found the macros, excellent :-)


Segher


More information about the SLOF mailing list