[Skiboot] [PATCH] hw/sbe: Add SBE quirk for mambo and awan

[Reza Arbab]

On Wed, Jan 15, 2025 at 11:50:08AM +1000, Nicholas Piggin wrote:
>There appears to be no device-tree test for the P9 SBE presence like
>there is for P8. The P9 device tree test looks for the "primary"
>property, but this doesn't really test SBE presence because all chips
>have an SBE. It just happens to work because mambo must not add that
>property.
>
>So add a platform quirk, and mark mambo and awan as not having SBE.
>
>This is needed for a later change that runs a health check on every
>SBE in the system.
>
>Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
>---
>This should be applied before the sbe timers series, and solves the
>mambo crash.

Applied to master.

>--- a/hw/sbe-p8.c
>+++ b/hw/sbe-p8.c
>@@ -168,6 +168,9 @@ void p8_sbe_init_timer(void)
> 	int64_t rc;
> 	uint32_t tick_us;
>
>+	if (proc_gen != proc_gen_p8 || chip_quirk(QUIRK_NO_SBE))
>+		return;
>+
> 	np = dt_find_compatible_node(dt_root, NULL, "ibm,power8-sbe-timer");
> 	if (!np)
> 		return;

I added an #include <chip.h> for this chunk, because

hw/sbe-p8.c: In function 'p8_sbe_init_timer':
hw/sbe-p8.c:173:40: error: implicit declaration of function 'chip_quirk' [-Wimplicit-function-declaration]
   173 |         if (proc_gen != proc_gen_p8 || chip_quirk(QUIRK_NO_SBE))
       |                                        ^~~~~~~~~~
hw/sbe-p8.c:173:51: error: 'QUIRK_NO_SBE' undeclared (first use in this function)
   173 |         if (proc_gen != proc_gen_p8 || chip_quirk(QUIRK_NO_SBE))
       |                                                   ^~~~~~~~~~~~

-- 
Reza Arbab