[Skiboot] [PATCH] platforms/qemu: QEMU now has support for direct controls on Power10

[Reza Arbab]

On Tue, Jan 14, 2025 at 04:31:28PM +1000, Nicholas Piggin wrote:
>On Sat Jan 11, 2025 at 3:55 AM AEST, Reza Arbab wrote:
>> On Mon, Nov 11, 2024 at 05:12:56PM +1000, Nicholas Piggin wrote:
>> >--- a/core/direct-controls.c
>> >+++ b/core/direct-controls.c
>> >@@ -1151,7 +1151,7 @@ int64_t opal_signal_system_reset(int cpu_nr)
>> >
>> > void direct_controls_init(void)
>> > {
>> >-	if (chip_quirk(QUIRK_MAMBO_CALLOUTS))
>> >+	if (chip_quirk(QUIRK_NO_DIRECT_CTL))
>> > 		return;
>> >
>> > 	if (proc_gen != proc_gen_p9 && proc_gen != proc_gen_p10)
>>
>> I think this function will now return early for "qemu,powernv9", where
>> it did not before, so no system reset callback will be registered at
>> all. Does that matter?
>
>Ah... no, I think QEMU powernv9 shouldn't have any direct controls
>either so the callback shouldn't have worked. Seems okay to not
>register it.

No problem then. Applied to master.

-- 
Reza Arbab