[Skiboot] [PATCH v4 3/6] plat/qemu: add support for Power11 platform

Nicholas Piggin npiggin at gmail.com
Thu Feb 27 13:29:17 AEDT 2025


On Fri Feb 21, 2025 at 4:25 AM AEST, Mahesh Salgaonkar wrote:
> From: Aditya Gupta <adityag at linux.ibm.com>
>
> Add support for QEMU simulator for Power11 when it starts supporting
> "qemu,powernv11" machines.
>
> Signed-off-by: Aditya Gupta <adityag at linux.ibm.com>
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.ibm.com>
> Reviewed-by: Nicholas Piggin <npiggin at gmail.com>
> ---
> Change in v4:
> - Moved psi.c and xscom.c hunks to patch 1
>
> Change in v3:
> - Add helper function to get proc_gen number
> - Print unknown processor detected in case of -ve proc_gen number
> ---
>  core/chip.c           |  1 +
>  platforms/qemu/qemu.c | 23 +++++++++++++++++++++++
>  2 files changed, 24 insertions(+)
>
> diff --git a/core/chip.c b/core/chip.c
> index 078f658a29..2df35f3ff6 100644
> --- a/core/chip.c
> +++ b/core/chip.c
> @@ -189,6 +189,7 @@ void init_chips(void)
>  	} else if (dt_node_is_compatible(dt_root, "qemu,powernv") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv8") ||
>  	    dt_node_is_compatible(dt_root, "qemu,powernv9") ||
> +	    dt_node_is_compatible(dt_root, "qemu,powernv11") ||
>  	    dt_find_by_path(dt_root, "/qemu")) {
>  		proc_chip_quirks |= QUIRK_QEMU | QUIRK_NO_DIRECT_CTL | QUIRK_NO_RNG;
>  		prlog(PR_NOTICE, "CHIP: Detected QEMU simulator\n");

I still think the qemu,powernv11 check should go in the previous if ()
{} with power10. It enables direct controls which powernv11 should just
support with the powernv10 code.

Thanks,
Nick


More information about the Skiboot mailing list