[Skiboot] [PATCH v2 2/6] cpufeatures: Add Power11 support

Cédric Le Goater clg at kaod.org
Thu Feb 6 18:25:01 AEDT 2025


On 2/6/25 07:17, Mahesh J Salgaonkar wrote:
> On 2025-02-05 09:09:03 Wed, Reza Arbab wrote:
>> On Mon, Feb 03, 2025 at 11:46:49AM +0530, Mahesh Salgaonkar wrote:
>>> --- a/core/cpufeatures.c
>>> +++ b/core/cpufeatures.c
>>> @@ -1033,6 +1034,13 @@ void dt_add_cpufeatures(struct dt_node *root)
>>> 		cpu_feature_isa = ISA_V3_1;
>>> 		cpu_feature_cpu = CPU_P10;
>>> 		break;
>>> +	case PVR_TYPE_P11:
>>> +		if (!cpu_name)
>>> +			cpu_name = "Power11";
>>> +
>>> +		cpu_feature_isa = ISA_V3_1;
>>> +		cpu_feature_cpu = CPU_P11;
>>> +		break;
>>> 	default:
>>> 		return;
>>> 	}
>>
>> Same question as in patch one. We have "POWER8", "POWER9", and "POWER10".
>> Shouldn't this be "POWER11" instead of "Power11"?
> 
> Power brand wants to export P11 and Power11. 'P' capital reset lower.

I think Power10 is the same. The brand name was changed after bringup.
That's why we still find capital letters in some places.


Thanks,

C.



> 
> Thanks,
> -Mahesh.
> 



More information about the Skiboot mailing list