[Skiboot] [PATCH 1/4] hw/occ: Fix version check

Nicholas Piggin npiggin at gmail.com
Mon Nov 18 00:33:46 AEDT 2024


This test is always false due to a typo, which disables OCC
sensor and command functions. Not sure why compiler doesn't warn about
always true condition.

Fixes: c8c36ada1d ("occ: Add POWER10 support")
Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
 hw/occ.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/occ.c b/hw/occ.c
index 8d7bcbec9..bf2b2f9d0 100644
--- a/hw/occ.c
+++ b/hw/occ.c
@@ -1522,7 +1522,7 @@ static void occ_cmd_interface_init(void)
 	chip = next_chip(NULL);
 	pdata = get_occ_pstate_table(chip);
 	major = pdata->version >> 4;
-	if (major != 0x9 || major != 0xA)
+	if (major != 0x9 && major != 0xA)
 		return;
 
 	for_each_chip(chip)
-- 
2.45.2



More information about the Skiboot mailing list