From arbab at linux.ibm.com  Sat Aug  3 04:20:12 2024
From: arbab at linux.ibm.com (Reza Arbab)
Date: Fri, 2 Aug 2024 13:20:12 -0500
Subject: [Skiboot] [PATCH] opal-ci: Drop fedora38, add fedora40
In-Reply-To: <20240524140859.38323-1-arbab@linux.ibm.com>
References: <20240524140859.38323-1-arbab@linux.ibm.com>
Message-ID: <287fdbbd-aeec-4014-b035-7f3e56fe3ed4@arbab-laptop>

On Fri, May 24, 2024 at 09:08:59AM -0500, Reza Arbab wrote:
>Fedora 38 has reached end-of-life. Remove it and add Fedora 40.

Applied to master.

-- 
Reza Arbab

From arbab at linux.ibm.com  Sat Aug  3 04:22:13 2024
From: arbab at linux.ibm.com (Reza Arbab)
Date: Fri, 2 Aug 2024 13:22:13 -0500
Subject: [Skiboot] [PATCH] core/pldm: Fix pdr handle to add first pdr
 request
In-Reply-To: <20240614072013.18125-1-abhishek@linux.ibm.com>
References: <20240614072013.18125-1-abhishek@linux.ibm.com>
Message-ID: <82a688b4-af4f-4922-9281-8b4344e2f5a2@arbab-laptop>

On Fri, Jun 14, 2024 at 12:50:13PM +0530, Abhishek Singh Tomar wrote:
>However, it's important to note that the first
>PDR may not necessarily have a handle of 1.
>
>In the current scenario, providing a record_hndl
>value of 0 to pldm_pdr_add() will always result
>in the addition of a record to the repository
>with a PDR handle of 1.
>
>In current fix record handle is extracted from
>pdr record data.

Looks good to me. Applied to master.

-- 
Reza Arbab

From arbab at linux.ibm.com  Sat Aug  3 04:25:59 2024
From: arbab at linux.ibm.com (Reza Arbab)
Date: Fri, 2 Aug 2024 13:25:59 -0500
Subject: [Skiboot] [PATCH 0/2] Pldm Platform fixes
In-Reply-To: <20240614074601.21174-2-abhishek@linux.ibm.com>
References: <20240614074601.21174-2-abhishek@linux.ibm.com>
Message-ID: <9ec9e81e-5701-43bd-8288-0c589fb9c74b@arbab-laptop>

On Fri, Jun 14, 2024 at 01:16:00PM +0530, Abhishek Singh Tomar wrote:
>Fix Pldm Platform dangling pointer and uninitialised value

Series applied to master. Thanks!

Just curious, were these ad hoc or were they found through some sort of 
functional testing?

-- 
Reza Arbab

From arbab at linux.ibm.com  Sat Aug  3 04:29:42 2024
From: arbab at linux.ibm.com (Reza Arbab)
Date: Fri,  2 Aug 2024 13:29:42 -0500
Subject: [Skiboot] [PATCH] Makefile: Use '--ignore-errors unused' with lcov
In-Reply-To: <20240802182943.179900-1-arbab@linux.ibm.com>
References: <20240802182943.179900-1-arbab@linux.ibm.com>
Message-ID: <20240802182943.179900-2-arbab@linux.ibm.com>

We are a bit overzealous in specifying arguments to 'lcov -r', listing
files (via wildcard) that are not actually in the tracefile.

This is harmless, but will cause newer lcov to generate an error message
of type 'unused'. Reduce this error to a warning.

Signed-off-by: Reza Arbab <arbab at linux.ibm.com>
---
 Makefile.main | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.main b/Makefile.main
index 5240d71b1457..d25d1c9cd954 100644
--- a/Makefile.main
+++ b/Makefile.main
@@ -413,7 +413,7 @@ skiboot.info: coverage external/pflash/pflash.info external/gard/gard.info
 	lcov -q -r $@ 'external/gard/*' -o $@
 	lcov -q -a $@ -a external/pflash/pflash.info -o $@
 	lcov -q -a $@ -a external/gard/gard.info -o $@
-	lcov -q -r $@ $(LCOV_EXCLUDE) -o $@ --rc lcov_branch_coverage=1
+	lcov -q -r $@ $(LCOV_EXCLUDE) -o $@ --rc lcov_branch_coverage=1 --ignore-errors unused
 
 doc:
 	make -C doc html
-- 
2.43.5


From arbab at linux.ibm.com  Sat Aug  3 04:29:43 2024
From: arbab at linux.ibm.com (Reza Arbab)
Date: Fri,  2 Aug 2024 13:29:43 -0500
Subject: [Skiboot] [PATCH] opal-ci: Remove centos7
In-Reply-To: <20240802182943.179900-1-arbab@linux.ibm.com>
References: <20240802182943.179900-1-arbab@linux.ibm.com>
Message-ID: <20240802182943.179900-3-arbab@linux.ibm.com>

CentOS 7 end of life was June 30, 2024.

Signed-off-by: Reza Arbab <arbab at linux.ibm.com>
---
 .github/workflows/docker-builds-checks.yml |  2 +-
 opal-ci/Dockerfile-centos7                 | 13 ---------
 opal-ci/build-centos7.sh                   | 32 ----------------------
 3 files changed, 1 insertion(+), 46 deletions(-)
 delete mode 100644 opal-ci/Dockerfile-centos7
 delete mode 100755 opal-ci/build-centos7.sh

diff --git a/.github/workflows/docker-builds-checks.yml b/.github/workflows/docker-builds-checks.yml
index ab57ca212afa..dd1339cd75ee 100644
--- a/.github/workflows/docker-builds-checks.yml
+++ b/.github/workflows/docker-builds-checks.yml
@@ -12,7 +12,7 @@ jobs:
       fail-fast: false
 
       matrix:
-        os: [ ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, ubuntu-rolling, centos7, fedora39, fedora40, fedora-rawhide, docs ]
+        os: [ ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, ubuntu-rolling, fedora39, fedora40, fedora-rawhide, docs ]
 
     steps:
       - uses: actions/checkout at v3
diff --git a/opal-ci/Dockerfile-centos7 b/opal-ci/Dockerfile-centos7
deleted file mode 100644
index 5055616c9a9a..000000000000
--- a/opal-ci/Dockerfile-centos7
+++ /dev/null
@@ -1,13 +0,0 @@
-FROM centos:7
-RUN yum -y update && yum clean all
-RUN yum -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl-devel openssl mbedtls-devel
-RUN mkdir /opt/cross
-RUN if [ `arch` = "x86_64" ]; then wget https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; tar -C /opt/cross -xf x86_64-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; fi
-RUN if [ `arch` = "ppc64le" ]; then wget https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/ppc64le/8.1.0/ppc64le-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; tar -C /opt/cross -xf ppc64le-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; fi
-RUN if [ `arch` = "x86_64" ]; then curl -L -O https://public.dhe.ibm.com/software/server/powerfuncsim/p8/packages/v1.0-2/systemsim-p8-1.0-2.el7.x86_64.rpm; yum install -y systemsim-p8-1.0-2.el7.x86_64.rpm; fi
-RUN if [ `arch` = "x86_64" ]; then curl -L -O https://public.dhe.ibm.com/software/server/powerfuncsim/p9/packages/v1.0-0/systemsim-p9-1.0-0.el7.x86_64.rpm; yum install -y systemsim-p9-1.0-0.el7.x86_64.rpm; fi
-RUN yum install -y flex bison
-RUN curl -L https://github.com/dgibson/dtc/archive/v1.4.2.tar.gz|tar xfz -
-RUN (cd dtc-1.4.2; make PREFIX=/usr/local install)
-COPY . /build/
-WORKDIR /build
diff --git a/opal-ci/build-centos7.sh b/opal-ci/build-centos7.sh
deleted file mode 100755
index 79b4c2e9b967..000000000000
--- a/opal-ci/build-centos7.sh
+++ /dev/null
@@ -1,32 +0,0 @@
-#!/bin/bash
-
-set -uo pipefail
-set -e
-set -vx
-
-# We're limited as to what we want to bother to run on CentOS7
-# It's fairly old and some of the things (e.g. build+run qemu) we don't
-# want to bother doing.
-if [ $(arch) == "x86_64" ]; then
-    export CROSS=/opt/cross/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-
-fi
-# Note that this doesn't work on centos7 because "/lib64/ld64.so.2: version `GLIBC_2.22' not found"
-if [ $(arch) == "ppc64le" ]; then
-    export CROSS=/opt/cross/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-
-fi
-
-MAKE_J=$(grep -c processor /proc/cpuinfo)
-
-make -j${MAKE_J} all
-make -j${MAKE_J} check
-(make clean; cd external/gard && CROSS= make -j${MAKE_J})
-(cd external/pflash; make -j${MAKE_J})
-make clean
-SKIBOOT_GCOV=1 make -j${MAKE_J}
-SKIBOOT_GCOV=1 make -j${MAKE_J} check
-
-make clean
-rm -rf builddir
-mkdir builddir
-make SRC=$(pwd) -f ../Makefile -C builddir -j${MAKE_J}
-make clean
-- 
2.43.5


From arbab at linux.ibm.com  Sat Aug  3 04:29:41 2024
From: arbab at linux.ibm.com (Reza Arbab)
Date: Fri,  2 Aug 2024 13:29:41 -0500
Subject: [Skiboot] [PATCH] ci: Update github actions to run on Node 20
Message-ID: <20240802182943.179900-1-arbab@linux.ibm.com>

Github is deprecating Node 16 for actions[1]. Update our workflow from
using actions/checkout at v3 to v4, which runs on Node 20.

[1] https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Signed-off-by: Reza Arbab <arbab at linux.ibm.com>
---
 .github/workflows/build-docs.yml           | 2 +-
 .github/workflows/docker-builds-checks.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml
index f9c17499d913..eb93e1e99854 100644
--- a/.github/workflows/build-docs.yml
+++ b/.github/workflows/build-docs.yml
@@ -12,7 +12,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout at v3
+        uses: actions/checkout at v4
 
       - name: Install apt dependencies
         run: sudo apt-get update &&
diff --git a/.github/workflows/docker-builds-checks.yml b/.github/workflows/docker-builds-checks.yml
index dd1339cd75ee..a6e66147a840 100644
--- a/.github/workflows/docker-builds-checks.yml
+++ b/.github/workflows/docker-builds-checks.yml
@@ -15,7 +15,7 @@ jobs:
         os: [ ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, ubuntu-rolling, fedora39, fedora40, fedora-rawhide, docs ]
 
     steps:
-      - uses: actions/checkout at v3
+      - uses: actions/checkout at v4
 
       - name: Create Docker image
         run: |
-- 
2.43.5


From dan at danny.cz  Sat Aug  3 05:00:36 2024
From: dan at danny.cz (Dan =?UTF-8?B?SG9yw6Fr?=)
Date: Fri, 2 Aug 2024 21:00:36 +0200
Subject: [Skiboot] [PATCH] opal-ci: Remove centos7
In-Reply-To: <20240802182943.179900-3-arbab@linux.ibm.com>
References: <20240802182943.179900-1-arbab@linux.ibm.com>
	<20240802182943.179900-3-arbab@linux.ibm.com>
Message-ID: <20240802210036.b68589a0569273a152271619@danny.cz>

On Fri,  2 Aug 2024 13:29:43 -0500
Reza Arbab <arbab at linux.ibm.com> wrote:

> CentOS 7 end of life was June 30, 2024.
> 
> Signed-off-by: Reza Arbab <arbab at linux.ibm.com>

LGTM

Reviewed-by: Dan Hor?k <dan at danny.cz>


		Dan

> ---
>  .github/workflows/docker-builds-checks.yml |  2 +-
>  opal-ci/Dockerfile-centos7                 | 13 ---------
>  opal-ci/build-centos7.sh                   | 32 ----------------------
>  3 files changed, 1 insertion(+), 46 deletions(-)
>  delete mode 100644 opal-ci/Dockerfile-centos7
>  delete mode 100755 opal-ci/build-centos7.sh
> 
> diff --git a/.github/workflows/docker-builds-checks.yml b/.github/workflows/docker-builds-checks.yml
> index ab57ca212afa..dd1339cd75ee 100644
> --- a/.github/workflows/docker-builds-checks.yml
> +++ b/.github/workflows/docker-builds-checks.yml
> @@ -12,7 +12,7 @@ jobs:
>        fail-fast: false
>  
>        matrix:
> -        os: [ ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, ubuntu-rolling, centos7, fedora39, fedora40, fedora-rawhide, docs ]
> +        os: [ ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, ubuntu-rolling, fedora39, fedora40, fedora-rawhide, docs ]
>  
>      steps:
>        - uses: actions/checkout at v3
> diff --git a/opal-ci/Dockerfile-centos7 b/opal-ci/Dockerfile-centos7
> deleted file mode 100644
> index 5055616c9a9a..000000000000
> --- a/opal-ci/Dockerfile-centos7
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -FROM centos:7
> -RUN yum -y update && yum clean all
> -RUN yum -y install wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl-devel openssl mbedtls-devel
> -RUN mkdir /opt/cross
> -RUN if [ `arch` = "x86_64" ]; then wget https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; tar -C /opt/cross -xf x86_64-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; fi
> -RUN if [ `arch` = "ppc64le" ]; then wget https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/ppc64le/8.1.0/ppc64le-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; tar -C /opt/cross -xf ppc64le-gcc-8.1.0-nolibc-powerpc64-linux.tar.xz; fi
> -RUN if [ `arch` = "x86_64" ]; then curl -L -O https://public.dhe.ibm.com/software/server/powerfuncsim/p8/packages/v1.0-2/systemsim-p8-1.0-2.el7.x86_64.rpm; yum install -y systemsim-p8-1.0-2.el7.x86_64.rpm; fi
> -RUN if [ `arch` = "x86_64" ]; then curl -L -O https://public.dhe.ibm.com/software/server/powerfuncsim/p9/packages/v1.0-0/systemsim-p9-1.0-0.el7.x86_64.rpm; yum install -y systemsim-p9-1.0-0.el7.x86_64.rpm; fi
> -RUN yum install -y flex bison
> -RUN curl -L https://github.com/dgibson/dtc/archive/v1.4.2.tar.gz|tar xfz -
> -RUN (cd dtc-1.4.2; make PREFIX=/usr/local install)
> -COPY . /build/
> -WORKDIR /build
> diff --git a/opal-ci/build-centos7.sh b/opal-ci/build-centos7.sh
> deleted file mode 100755
> index 79b4c2e9b967..000000000000
> --- a/opal-ci/build-centos7.sh
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -#!/bin/bash
> -
> -set -uo pipefail
> -set -e
> -set -vx
> -
> -# We're limited as to what we want to bother to run on CentOS7
> -# It's fairly old and some of the things (e.g. build+run qemu) we don't
> -# want to bother doing.
> -if [ $(arch) == "x86_64" ]; then
> -    export CROSS=/opt/cross/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-
> -fi
> -# Note that this doesn't work on centos7 because "/lib64/ld64.so.2: version `GLIBC_2.22' not found"
> -if [ $(arch) == "ppc64le" ]; then
> -    export CROSS=/opt/cross/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-
> -fi
> -
> -MAKE_J=$(grep -c processor /proc/cpuinfo)
> -
> -make -j${MAKE_J} all
> -make -j${MAKE_J} check
> -(make clean; cd external/gard && CROSS= make -j${MAKE_J})
> -(cd external/pflash; make -j${MAKE_J})
> -make clean
> -SKIBOOT_GCOV=1 make -j${MAKE_J}
> -SKIBOOT_GCOV=1 make -j${MAKE_J} check
> -
> -make clean
> -rm -rf builddir
> -mkdir builddir
> -make SRC=$(pwd) -f ../Makefile -C builddir -j${MAKE_J}
> -make clean
> -- 
> 2.43.5
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot

From abhishek at linux.ibm.com  Fri Aug 16 16:41:48 2024
From: abhishek at linux.ibm.com (Abhishek Singh Tomar)
Date: Fri, 16 Aug 2024 12:11:48 +0530
Subject: [Skiboot] [PATCH 0/2] Pldm Platform fixes
In-Reply-To: <9ec9e81e-5701-43bd-8288-0c589fb9c74b@arbab-laptop>
References: <20240614074601.21174-2-abhishek@linux.ibm.com>
 <9ec9e81e-5701-43bd-8288-0c589fb9c74b@arbab-laptop>
Message-ID: <cf482f3a-1149-4977-ab72-c07a6968772a@linux.ibm.com>

Hi Rezza

I am writing self test for PLDM in that efforts I discovered these issues


On 02/08/24 23:55, Reza Arbab wrote:
> these ad hoc or were they found through some sort of functional testing?