From arbab at linux.ibm.com  Thu Oct 12 08:59:25 2023
From: arbab at linux.ibm.com (Reza Arbab)
Date: Wed, 11 Oct 2023 16:59:25 -0500
Subject: [Skiboot] [PATCH 1/7] hdata: Add POWER10 Rainier tests
In-Reply-To: <20230906101017.130276-2-npiggin@gmail.com>
References: <20230906101017.130276-1-npiggin@gmail.com>
 <20230906101017.130276-2-npiggin@gmail.com>
Message-ID: <4697f706-223d-43a6-9d2c-4dab6a008c14@arbab-laptop>

I hit a couple of strange glitches processing this patch. No big deal, 
but thought it might be worth mentioning.

On Wed, Sep 06, 2023 at 08:10:11PM +1000, Nicholas Piggin wrote:
>+	vpd {
>+		phandle = <0x09>;
>+		compatible = "ibm,opal-v3-vpd";
>+		#size-cells = <0x00>;
>+		#address-cells = <0x01>;
>+		ibm,vpd = [84 7c 00 52 54 04 56 49 4e 49 42 33 06 00 00 00 00 00 00 42 34 01 00 42 37 0c 00 00 00 00 00 00 00 00 00 00 00 00 43 43 04 32 45 32 44 43 45 01 31 43 54 04 40 18 00 0c 44 52 10 53 59 53 54 45 4d 20 42 41 43 4b 50 4c 41 4e 45 46 4e 07 30 32 57 47 36 37 36 48 45 04 30 30 30 31 48 57 02 00 01 50 4e 07 30 32 57 47 36 37 38 53 4e 0c 59 31 33 31 55 46 30 37 33 30 32 54 56 5a 02 30 31 78 84 aa 00 52 54 04 56 53 59 53 42 52 02 53 30 44 52 06 53 59 53 54 45 4d 46 56 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 49 44 02 20 20 4d 4e 07 20 20 20 20 20 20 20 4e 4e 10 43 30 35 30 37 36 30 42 39 34 34 36 20 20 20 20 52 42 04 31 20 20 20 52 47 04 00 00 00 00 53 45 07 31 33 39 46 32 36 30 53 47 07 20 20 20 20 20 20 20 53 55 06 00 04 ac 1e 65 5a 54 4d 08 39 31 30 35 2d 32 32 41 54 4e 08 20 20 20 20 20 20 20 20 57 4e 0c 20 20 20 20 20 20 20 20 20 20 20 20 78 84 17 00 52 54 04 4c 58 52 30 4c 58 08 31 00 04 01 00 30 00 71 56 5a 02 30 31

Something added breaks to these long ibm,vpd lines. I'm curious what.  
Doubt it would be git-send-email. Something in the mail server chain?

> 78 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00];
>+		ibm,loc-code = "U9105.22A.139F260";
>+
>+		root-node-vpd at a000 {
>+			phandle = <0x0a>;
>+			ibm,loc-code = "U9105.22A.139F260";
>+			fru-type = [56 56];
>+			reg = <0xa000>;
>+			#size-cells = <0x00>;
>+			#address-cells = <0x01>;
>+			ibm,vpd = [84 6a 00 44 52 10 50 52 4f 43 45 53 53 4f 52 20 4d 4f 44 55 4c 45 56 5a 02 20 20 43 43 04 41 42 34 32 43 45 01 31 46 4e 07 46 32 31 30 31 31 30 50 4e 07 30 33 4a 4d 32 39 30 53 4e 0c 59 41 33 39 33 36 30 38 39 37 33 37 50 52 08 37 00 00 01 00 00 80 01 48 45 04 30 30 30 31 43 54 04 00 00 00 00 48 57 02 00 01 50 46 03 00 00 00 78 00 00 00 30 00 38 00 00];
>+
>+			enclosure at 1e00 {
>+				phandle = <0x0c>;
>+				ibm,loc-code = "U78DA.ND0.WZS003Y";
>+				fru-type = [45 56];
>+				reg = <0x1e00>;
>+				#size-cells = <0x00>;
>+				#address-cells = <0x01>;
>+
>+				backplane at 800 {
>+					phandle = <0x0d>;
>+					ibm,loc-code = "U78DA.ND0.WZS003Y-P0";
>+					fru-type = [42 50];
>+					reg = <0x800>;
>+					#size-cells = <0x00>;
>+					#address-cells = <0x01>;
>+					ibm,vpd = [84 7c 00 52 54 04 56 49 4e 49 42 33 06 00 00 00 00 00 00 42 34 01 00 42 37 0c 00 00 00 00 00 00 00 00 00 00 00 00 43 43 04 32 45 32 44 43 45 01 31 43 54 04 40 18 00 0c 44 52 10 53 59 53 54 45 4d 20 42 41 43 4b 50 4c 41 4e 45 46 4e 07 30 32 57 47 36 37 36 48 45 04 30 30 30 31 48 57 02 00 01 50 4e 07 30 32 57 47 36 37 38 53 4e 0c 59 31 33 31 55 46 30 37 33 30 32 54 56 5a 02 30 31 78 84 aa 00 52 54 04 56 53 59 53 42 52 02 53 30 44 52 06 53 59 53 54 45 4d 46 56 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 49 44 02 20 20 4d 4e 07 20 20 20 20 20 20 20 4e 4e 10 43 30 35 30 37 36 30 42 39 34 34 36 20 20 20 20 52 42 04 31 20 20 20 52 47 04 00 00 00 00 53 45 07 31 33 39 46 32 36 30 53 47 07 20 20 20 20 20 20 20 53 55 06 00 04 ac 1e 65 5a 54 4d 08 39 31 30 35 2d 32 32 41 54 4e 08 20 20 20 20 20 20 20 20 57 4e 0c 20 20 20 20 20 20 20 20 20 20 20 20 78 84 17 00 52 54 04 4c 58 52 30 4c 58 08 31 00 04 01 00 30 00 71 56 5a 02 30

Another line break.

> 31 78 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00];
>+					fru-number = "02WG676";
[snip]

>diff --git a/hdata/test/p10-rainier.spiras b/hdata/test/p10-rainier.spiras
>new file mode 100644
>index 0000000000000000000000000000000000000000..82da68c53986c0dedd9d6d3c33b1e069cd86a0bf

This was the the other thing that bit me. On patchwork, this hunk with 
the binary file is broken. The three lines above are the same, but all 
the following "GIT binary patch" data is moved to the top of the 
message.

https://patchwork.ozlabs.org/project/skiboot/patch/20230906101017.130276-2-npiggin at gmail.com/

git will apply the patchwork version of the patch without complaint, but 
the resulting p10-rainier.spiras is 0 bytes.

>GIT binary patch
>literal 8388608
>zcmeEP2VfLM_n$3ymxPofg%m<^>9oL=G!#t_1d?zhM<`MfQV0-Q61u=45$U3Wy`Z3f
>z73D(#MF9y#<x|A)iHf2U1k0zQ_=$=N-v7<s?A_jFLjpOKGLy``oi}gZoBh4n+48m=
>zK2v1OEle*$2&Ey!K}H%OGw^FoT7+1mSOBVq><d`~IS4Y+X;?F2;197-Vs>JlH0d-v
[snip]
>zfB*pk1PBlyK!5-N0t5&UAV7cs0RjXF5FkK+009C72oNAZfB*pk1PBlyK!5-N0t5&U
>zAV7cs0RjXF5FkK+009C72oNAZfB*pk1PBlyK!5-N0t5&UAV7cs0RjXF5FkK+009C7
>l2oNAZfB*pk1PBlyK!5-N0t5&UAV7cs0RjXF5ct0o_&4Rz!iN9=
>
>literal 0
>HcmV?d00001
>
>-- 
>2.40.1

(I'm using 2.39.3, fwiw)

-- 
Reza Arbab

From arbab at linux.ibm.com  Thu Oct 12 08:59:57 2023
From: arbab at linux.ibm.com (Reza Arbab)
Date: Wed, 11 Oct 2023 16:59:57 -0500
Subject: [Skiboot] [PATCH 0/7] hdata: P10 tests and cleanups
In-Reply-To: <20230906101017.130276-1-npiggin@gmail.com>
References: <20230906101017.130276-1-npiggin@gmail.com>
Message-ID: <3e94ab6f-9531-47b2-8d8c-832c8d72e52f@arbab-laptop>

On Wed, Sep 06, 2023 at 08:10:10PM +1000, Nicholas Piggin wrote:
>I started looking at adding HDAT building support a while back,
>that's not going anywhere very soon, but in the process made a few
>cleanups and added P10 tests.

Series applied to master.

-- 
Reza Arbab