[Skiboot] [PATCH V4 7/9] libmctp: Import libmctp library handling MCTP protocol

[Nicholas Piggin]

On Wed Jun 21, 2023 at 12:52 AM AEST, Christophe Lombard wrote:
> The Management Component Transport Protocol (MCTP) is a protocol defined by
> the DMTF Platform Management Component Intercommunications sub-team of the
> DMTF Pre-OS Workgroup. MCTP is designed to support communications between
> different intelligent hardware components that make up a platform
> management subsystem that is provides monitoring and control functions
> inside a managed system. DMTF standard "DSP2016"
>
> This library is intended to be a portable implementation of the Management
> Component Transport Protocol (MCTP), as defined by DMTF standard "DSP0236",
> plus transport binding specifications.
> MCTP has been designed to carry multiple types of manageability-related
> traffic across a common medium. The base MCTP specifications define
> message types for supporting the initialization and configuration of MCTP
> itself, and to support vendor-specific messages over MCTP.
> Other message types, such as message types to support a Platform Level
> Data Model (PLDM).
>
> The source is located here: https://github.com/openbmc/libmctp and use as
> is, without any update.
>
> The libmctp code is integrated into the folder ./libmctp as a set of
> sources, compiled if the compiler flag CONFIG_PLDM is set.
>
> A config file is required. Not being generated automatically by 'configure',
> it must be edited manually to match the environment.

So nothing actually uses this yet as of this commit, it just builds it?

> diff --git a/libmctp/README.skiboot b/libmctp/README.skiboot
> new file mode 100644
> index 00000000..cbdcb7a8
> --- /dev/null
> +++ b/libmctp/README.skiboot
> @@ -0,0 +1,15 @@
> +skiboot/libmctp/ is a minimally modified version of upstream libmctp
> +that is distributed with the openbmc project hosted at
> +https://github.com/openbmc/libmctp.git
> +
> +This version is taken from libmctp.git commit 4df106db7766d ("astlpc: Add
> +mctp_astlpc_tx_done() API") by copying most
> +of files from the libmctp/ directory.
> +
> +The only modifications from the upstream source are the additions of
> +this file, Makefile.inc which has been derived from the original
> +Makefile.inc, astlpc.c (compilation error when MCTP_HAVE_FILEIO is
> +undefined) and the removal of several unnecessary folders and files.

Also the addition of config.h?

I know nothing of MCTP but build changes and the README file look good.

Acked-by: Nicholas Piggin <npiggin at gmail.com>