[Skiboot] [PATCH] pci: Remove set_mve

Joel Stanley joel at jms.id.au
Tue Jun 20 10:33:37 AEST 2023


These callbacks were used by the p7ioc code that was removed a long time
ago.

Signed-off-by: Joel Stanley <joel at jms.id.au>
---
 include/pci.h   |  6 ------
 core/pci-opal.c | 36 ++++++++----------------------------
 2 files changed, 8 insertions(+), 34 deletions(-)

diff --git a/include/pci.h b/include/pci.h
index caae74431841..59f9fcc9afaa 100644
--- a/include/pci.h
+++ b/include/pci.h
@@ -296,12 +296,6 @@ struct phb_ops {
 	int64_t (*get_option)(struct phb *phb, enum OpalPhbOption opt,
 			      __be64 *setting);
 
-	int64_t (*set_mve)(struct phb *phb, uint32_t mve_number,
-			   uint64_t pe_number);
-
-	int64_t (*set_mve_enable)(struct phb *phb, uint32_t mve_number,
-				  uint32_t state);
-
 	int64_t (*set_xive_pe)(struct phb *phb, uint64_t pe_number,
 			       uint32_t xive_num);
 
diff --git a/core/pci-opal.c b/core/pci-opal.c
index acbcd2a5e60a..71e270f13a77 100644
--- a/core/pci-opal.c
+++ b/core/pci-opal.c
@@ -307,39 +307,19 @@ static int64_t opal_pci_set_peltv(uint64_t phb_id, uint32_t parent_pe,
 }
 opal_call(OPAL_PCI_SET_PELTV, opal_pci_set_peltv, 4);
 
-static int64_t opal_pci_set_mve(uint64_t phb_id, uint32_t mve_number,
-				uint64_t pe_number)
+static int64_t opal_pci_set_mve(uint64_t phb_id __unused,
+				uint32_t mve_number __unused,
+				uint64_t pe_number __unused)
 {
-	struct phb *phb = pci_get_phb(phb_id);
-	int64_t rc;
-
-	if (!phb)
-		return OPAL_PARAMETER;
-	if (!phb->ops->set_mve)
-		return OPAL_UNSUPPORTED;
-	phb_lock(phb);
-	rc = phb->ops->set_mve(phb, mve_number, pe_number);
-	phb_unlock(phb);
-
-	return rc;
+	return OPAL_UNSUPPORTED;
 }
 opal_call(OPAL_PCI_SET_MVE, opal_pci_set_mve, 3);
 
-static int64_t opal_pci_set_mve_enable(uint64_t phb_id, uint32_t mve_number,
-				       uint32_t state)
+static int64_t opal_pci_set_mve_enable(uint64_t phb_id __unused,
+				       uint32_t mve_number __unused,
+				       uint32_t state __unused)
 {
-	struct phb *phb = pci_get_phb(phb_id);
-	int64_t rc;
-
-	if (!phb)
-		return OPAL_PARAMETER;
-	if (!phb->ops->set_mve_enable)
-		return OPAL_UNSUPPORTED;
-	phb_lock(phb);
-	rc = phb->ops->set_mve_enable(phb, mve_number, state);
-	phb_unlock(phb);
-
-	return rc;
+	return OPAL_UNSUPPORTED;
 }
 opal_call(OPAL_PCI_SET_MVE_ENABLE, opal_pci_set_mve_enable, 3);
 
-- 
2.39.2



More information about the Skiboot mailing list