[Skiboot] [PATCH V6 21/21] core/pldm: Get file handle and file length

[Christophe Lombard]

Le 13/04/2023 à 10:16, Frederic Barrat a écrit :
>
>
> On 13/09/2022 12:27, Christophe Lombard wrote:
>> +    if (*file_length == 0) {
>> +        prlog(PR_ERR, "%s - No file handle found, lid_id: %s\n",
>> +                  __func__, lid_id);
>> +        *file_handle = 0xff;
>> +        *file_length = 0;
>> +        return OPAL_PARAMETER;
>> +    }
>> +
>> +    prlog(PR_DEBUG, "%s - lid_id: %s, file_handle: %d, file_length: 
>> %d\n",
>> +            __func__, lid_id, *file_handle, *file_length);
>
>
> Sample output:
> [  731.487189876,7] PLDM: find_file_handle_by_lid_id - lid_id: 
> 81e0065b, file_handle: 16, file_length: 36864
> [  731.487256752,7] PLDM: find_file_handle_by_lid_id - lid_id: 
> 81e0068d, file_handle: 8, file_length: 872448
> [  731.487326403,3] PLDM: find_file_handle_by_lid_id - No file handle 
> found, lid_id: 81e00630
> [  731.487405540,7] PLDM: find_file_handle_by_lid_id - lid_id: 
> 81e00676, file_handle: 36, file_length: 2097152
> [  731.487479586,7] PLDM: find_file_handle_by_lid_id - lid_id: 
> 81e00668, file_handle: 10, file_length: 147456
>
>
> Nitpick: can we format the messages so that the lid_id's are aligned 
> between the PR_DEBUG and PR_ERR message? i.e:
>
> prlog(PR_ERR, "%s - lid_id: %s, no file handle found\n", __func__, 
> lid_id);
>

sure. Thanks

> Fred