[Skiboot] [PATCH V2 09/10] pldm/libpldm: Import libpldm library handling PLDM protocol

Frederic Barrat fbarrat at linux.ibm.com
Tue Apr 4 02:38:18 AEST 2023



On 15/03/2022 13:49, Christophe Lombard wrote:
> diff --git a/pldm/libpldm/Makefile.inc b/pldm/libpldm/Makefile.inc
> new file mode 100644
> index 00000000..22ecc82e
> --- /dev/null
> +++ b/pldm/libpldm/Makefile.inc
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later
> +# Copyright 2022 IBM Corp.
> +
> +LIBPLDM_DIR ?= pldm/libpldm
> +SUBDIRS += $(LIBPLDM_DIR)
> +
> +LIBPLDM_OBJS = base.o platform.o bios.o bios_table.o fru.o utils.o
> +LIBPLDM_OBJS += pdr.o firmware_update.o
> +
> +CFLAGS_$(LIBPLDM_DIR)/ = -I$(SRC)/ccan/endian/  \


Same as with libmctp, you can drop the ccan/endian directory from the 
include list.

Other than that, the import looks good. Like with mctp, we probably need 
to refresh it with the latest libpldm content.

   Fred


More information about the Skiboot mailing list