[Skiboot] [PATCH V6 17/21] core/pldm: Update "bmc-firmware-version" device-tree field

Christophe Lombard clombard at linux.vnet.ibm.com
Tue Sep 13 20:27:01 AEST 2022


Use the GetFruRecordByOptionReq command to retrieve the bmc information
with: "FRU Field Type": Version
      "FRU Record Set Identifier": 1,
      "FRU Record Type": "General(1)"
and update the "bmc-firmware-version" device-tree field.

Signed-off-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
---
 core/pldm/pldm-fru-requests.c | 60 +++++++++++++++++++++++++++++++++++
 core/pldm/pldm.h              |  1 +
 include/pldm.h                |  5 +++
 3 files changed, 66 insertions(+)

diff --git a/core/pldm/pldm-fru-requests.c b/core/pldm/pldm-fru-requests.c
index 02c9b968..b07a7b1a 100644
--- a/core/pldm/pldm-fru-requests.c
+++ b/core/pldm/pldm-fru-requests.c
@@ -15,6 +15,7 @@ static void *fru_record_table;
 static size_t fru_record_length;
 
 static bool fru_ready;
+static char *bmc_version = NULL;
 
 static void fru_init_complete(bool success)
 {
@@ -33,6 +34,16 @@ static void fru_init_complete(bool success)
 	fru_ready = true;
 }
 
+int pldm_fru_get_bmc_version(void *bv)
+{
+	if (bmc_version == NULL)
+		return OPAL_HARDWARE;
+
+	memcpy(bv, bmc_version, strlen(bmc_version) + 1);
+
+	return OPAL_SUCCESS;
+}
+
 static int get_fru_record_table_req(void **record_table_data,
 				    size_t *record_table_length)
 {
@@ -115,6 +126,55 @@ static int get_fru_record_table_req(void **record_table_data,
 	return OPAL_SUCCESS;
 }
 
+int pldm_fru_dt_add_bmc_version(void)
+{
+	struct pldm_fru_record_data_format *data;
+	struct pldm_fru_record_tlv *tlv;
+	struct dt_node *dt_fw_version;
+	uint8_t *record_table;
+	size_t record_size;
+
+	dt_fw_version = dt_find_by_name(dt_root, "ibm,firmware-versions");
+	if (!dt_fw_version)
+		return OPAL_SUCCESS;
+
+	/* retrieve the bmc information with
+	 * "FRU Record Set Identifier": 1,
+	 * "FRU Record Type": "General(1)"
+	 * "FRU Field Type": Version
+	 *
+	 * we can not know size of the record table got by options
+	 * in advance, but it must be less than the source table. So
+	 * it's safe to use sizeof the source table.
+	 */
+	record_table = zalloc(fru_record_length);
+	record_size = fru_record_length;
+	get_fru_record_by_option(
+			fru_record_table,
+			fru_record_length - PLDM_GET_FRU_RECORD_TABLE_MIN_RESP_BYTES,
+			record_table,
+			&record_size,
+			1,
+			PLDM_FRU_RECORD_TYPE_GENERAL,
+			PLDM_FRU_FIELD_TYPE_VERSION);
+
+	/* get tlv value */
+	data = (struct pldm_fru_record_data_format *)record_table;
+	tlv = (struct pldm_fru_record_tlv *)data->tlvs;
+	prlog(PR_DEBUG, "%s - value: %s\n", __func__, tlv->value);
+
+	dt_add_property_string(dt_fw_version, "bmc-firmware-version",
+			       tlv->value);
+
+	/* store the bmc version */
+	bmc_version = zalloc(tlv->length + 1);
+	memcpy(bmc_version, tlv->value, tlv->length);
+
+	free(record_table);
+
+	return OPAL_SUCCESS;
+}
+
 int pldm_fru_init(void)
 {
 	int rc;
diff --git a/core/pldm/pldm.h b/core/pldm/pldm.h
index f9e9db40..5ee53cb9 100644
--- a/core/pldm/pldm.h
+++ b/core/pldm/pldm.h
@@ -47,6 +47,7 @@ int pldm_responder_handle_request(struct pldm_rx_data *rx);
 int pldm_responder_init(void);
 
 /* Requester support */
+int pldm_fru_get_bmc_version(void *bv);
 int pldm_fru_init(void);
 
 int pldm_bios_find_lid_by_attr_name(const char *name, char **lid);
diff --git a/include/pldm.h b/include/pldm.h
index 3e653aa3..693c1ae5 100644
--- a/include/pldm.h
+++ b/include/pldm.h
@@ -25,4 +25,9 @@ int pldm_platform_power_off(void);
  */
 int pldm_platform_restart(void);
 
+/**
+ * Update the firmware version device-tree field
+ */
+int pldm_fru_dt_add_bmc_version(void);
+
 #endif /* __PLDM_H__ */
-- 
2.37.3



More information about the Skiboot mailing list