[Skiboot] [PATCH V3 10/15] core/pldm: Decode the GetFRURecordTableMetadata request

Abhishek SIngh Tomar abhishek at linux.ibm.com
Mon Oct 3 16:19:46 AEDT 2022


On Tue, Sep 13, 2022 at 12:27:19PM +0200, Christophe Lombard wrote:
> The GetFRURecordTableMetadata command is used to get the FRU Record
> Table metadata information that includes the FRU Record major version,
> the FRU Record minor version, the size of the largest FRU Record data,
> total length of the FRU Record Table, total number of FRU Record Data
> structures, and the integrity checksum on the FRU Record Table data.
> 
> Add an "IBM, skiboot" FRU Record product requested by the BMC.
> 
> Signed-off-by: Christophe Lombard <clombard at linux.vnet.ibm.com>
Reviewed-by : Abhishek Singh Tomar
> ---
>  core/pldm/pldm-fru-requests.c | 53 ++++++++++++++++++++++
>  core/pldm/pldm-responder.c    | 85 +++++++++++++++++++++++++++++++++++
>  core/pldm/pldm.h              |  3 ++
>  3 files changed, 141 insertions(+)
> 
> diff --git a/core/pldm/pldm-fru-requests.c b/core/pldm/pldm-fru-requests.c
> index b07a7b1a..80a13ef1 100644
> --- a/core/pldm/pldm-fru-requests.c
> +++ b/core/pldm/pldm-fru-requests.c
> @@ -14,6 +14,9 @@
>  static void *fru_record_table;
>  static size_t fru_record_length;
> 
> +static void *local_fru_record_table;
> +static size_t local_fru_table_length;
> +
>  static bool fru_ready;
>  static char *bmc_version = NULL;
> 
> @@ -175,6 +178,56 @@ int pldm_fru_dt_add_bmc_version(void)
>  	return OPAL_SUCCESS;
>  }
> 
> +#define RECORD_SET_ID 100
> +
> +void pldm_fru_add_record(uint32_t *table_length,
> +			 uint16_t *total_record_set_identifiers,
> +			 uint16_t *total_table_records)
> +{
> +	struct pldm_fru_record_data_format *record;
> +	struct pldm_fru_record_tlv *fru_tlv;
> +	size_t fru_table_size, record_size;
> +	char fru_product[] = "IBM, skiboot";
> +
> +	if (local_fru_record_table) {
> +		*table_length = local_fru_table_length;
> +		*total_record_set_identifiers =  1;
> +		*total_table_records = 1;
> +		return;
> +	}
> +
> +	/* allocate fru table */
> +	fru_table_size = sizeof(struct pldm_fru_record_data_format) +
> +			 sizeof(struct pldm_fru_record_tlv) +
> +			 strlen(fru_product);
> +	local_fru_record_table = zalloc(fru_table_size);
> +
> +	/* fill fru record data */
> +	record = (struct pldm_fru_record_data_format *)local_fru_record_table;
> +	record->record_set_id = htole16(RECORD_SET_ID);
> +	record->record_type = PLDM_FRU_RECORD_TYPE_GENERAL;
> +	record->num_fru_fields = 1;
> +	record->encoding_type = PLDM_FRU_ENCODING_ASCII;
> +
> +	/* to start, set the size as the start of the TLV structs */
> +	record_size = offsetof(struct pldm_fru_record_data_format, tlvs);
> +
> +	/* TLVs data */
> +	fru_tlv = (struct pldm_fru_record_tlv *)(local_fru_record_table + record_size);
> +	fru_tlv->type = PLDM_FRU_FIELD_TYPE_OTHER;
> +	fru_tlv->length = strlen(fru_product);
> +	memcpy(fru_tlv->value, fru_product, fru_tlv->length);
> +
> +	/* increment record_size by total size of this TLV */
> +	record_size += (offsetof(struct pldm_fru_record_tlv, value) + fru_tlv->length);
> +
> +	*table_length = record_size;
> +	*total_record_set_identifiers =  1;
> +	*total_table_records = 1;
> +
> +	local_fru_table_length = *table_length;
> +}
> +
>  int pldm_fru_init(void)
>  {
>  	int rc;
> diff --git a/core/pldm/pldm-responder.c b/core/pldm/pldm-responder.c
> index 8fbd57c3..cd2cbc1c 100644
> --- a/core/pldm/pldm-responder.c
> +++ b/core/pldm/pldm-responder.c
> @@ -11,6 +11,7 @@
>  #include <opal-msg.h>
>  #include <debug_descriptor.h>
>  #include <pldm/ibm/libpldm/platform_oem_ibm.h>
> +#include <pldm/libpldm/fru.h>
>  #include <pldm/libpldm/platform.h>
>  #include <pldm/libpldm/state_set.h>
>  #include <pldm/libpldm/utils.h>
> @@ -914,6 +915,86 @@ static struct pldm_cmd pldm_platform_get_pdr = {
>  	.handler = platform_get_pdr_handle,
>  };
> 
> +/*
> + * PLDM Fru commands support
> + */
> +static struct pldm_type pldm_fru_type = {
> +	.name = "fru",
> +	.pldm_type_id = PLDM_FRU,
> +};
> +
> +/* currently we support version 1.0 of fru table */
> +#define SUPPORTED_FRU_VERSION_MAJOR 1
> +#define SUPPORTED_FRU_VERSION_MINOR 0
> +
> +/* Used by the metadata request handler for the value of
> + * FRUTableMaximumSize
> + * 0 means SetFRURecordTable command is not supported (see DSP 0257
> + * v1.0.0 Table 9)
> + */
> +#define FRU_TABLE_MAX_SIZE_UNSUPPORTED 0
> +
> +/*
> + * GetFRURecordTableMetadata (0X01)
> + * The GetFRURecordTableMetadata command is used to get the FRU Record
> + * Table metadata information that includes the FRU Record major
> + * version, the FRU Record minor version, the size of the largest FRU
> + * Record data, total length of the FRU Record Table, total number of
> + * FRU Record Data structures, and the integrity checksum on the FRU
> + * Record Table data.
> + */
> +static int fru_get_record_table_metadata_handler(const struct pldm_rx_data *req)
> +{
> +	char response_msg[PKT_SIZE(struct pldm_get_fru_record_table_metadata_resp)];
> +	uint16_t total_record_set_identifiers, total_table_records;
> +	uint32_t fru_table_length;
> +	int rc;
> +
> +	/*
> +	 * GetFRURecordTableMetadata requests
> +	 * don't have any payload, so no need to decode them
> +	 */
> +
> +	/* add specific fru record */
> +	pldm_fru_add_record(&fru_table_length,
> +			    &total_record_set_identifiers,
> +			    &total_table_records);
> +
> +	/* create a PLDM response message for GetFRURecordTableMetadata */
> +	rc = encode_get_fru_record_table_metadata_resp(
> +				req->hdrinf.instance,
> +				PLDM_SUCCESS,
> +				SUPPORTED_FRU_VERSION_MAJOR,
> +				SUPPORTED_FRU_VERSION_MINOR,
> +				FRU_TABLE_MAX_SIZE_UNSUPPORTED,
> +				fru_table_length,
> +				total_record_set_identifiers,
> +				total_table_records,
> +				0, // checksum, not calculated
> +				(struct pldm_msg *)response_msg);
> +	if (rc != PLDM_SUCCESS) {
> +		prlog(PR_ERR, "Encode GetFRURecordTableMetadata Error, rc: %d\n", rc);
> +		cc_resp(req, req->hdrinf.pldm_type,
> +			req->hdrinf.command, PLDM_ERROR);
> +		return OPAL_PARAMETER;
> +	}
> +
> +	/* send PLDM message over MCTP */
> +	rc = pldm_mctp_message_tx(req->source_eid, response_msg, sizeof(response_msg));
> +	if (rc) {
> +		prlog(PR_ERR, "Failed to send GetFRURecordTableMetadata response, rc = %d\n", rc);
> +		return OPAL_HARDWARE;
> +	}
> +
> +	return OPAL_SUCCESS;
> +}
> +
> +static struct pldm_cmd pldm_fru_get_record_table_metadata = {
> +	.name = "PLDM_GET_FRU_RECORD_TABLE_METADATA",
> +	.pldm_cmd_id = PLDM_GET_FRU_RECORD_TABLE_METADATA,
> +	.handler = fru_get_record_table_metadata_handler,
> +};
> +
>  int pldm_responder_handle_request(struct pldm_rx_data *rx)
>  {
>  	const struct pldm_type *type;
> @@ -962,5 +1043,9 @@ int pldm_responder_init(void)
>  	add_cmd(&pldm_platform_type, &pldm_platform_set_state_effecter_states);
>  	add_cmd(&pldm_platform_type, &pldm_platform_get_pdr);
> 
> +	/* Register fru commands we'll respond to - DSP0257 */
> +	add_type(&pldm_fru_type);
> +	add_cmd(&pldm_fru_type, &pldm_fru_get_record_table_metadata);
> +
>  	return OPAL_SUCCESS;
>  }
> diff --git a/core/pldm/pldm.h b/core/pldm/pldm.h
> index af8c8925..fea06b0b 100644
> --- a/core/pldm/pldm.h
> +++ b/core/pldm/pldm.h
> @@ -75,6 +75,9 @@ int pldm_file_io_write_file(uint32_t file_handle, const void *buf,
>  int pldm_file_io_init(void);
> 
>  int pldm_fru_get_bmc_version(void *bv);
> +void pldm_fru_add_record(uint32_t *fru_table_length,
> +			 uint16_t *total_record_set_identifiers,
> +			 uint16_t *total_table_records);
>  int pldm_fru_init(void);
> 
>  int pldm_bios_find_lid_by_attr_name(const char *name, char **lid);
> -- 
> 2.37.3
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot


More information about the Skiboot mailing list